Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shared framework target to support Carthage. #33

Merged
merged 2 commits into from
Sep 7, 2015
Merged

Added shared framework target to support Carthage. #33

merged 2 commits into from
Sep 7, 2015

Conversation

regexident
Copy link
Contributor

Follow-up for issue #19.

Carthage needs to find the xcodeproj and a shared framework target.
As such it is impedimental to have multiple xcodeproj files and subprojects, especially when the xcodeproj file has a different name than the Project and no shared framework.

@regexident
Copy link
Contributor Author

Any particular reason for closing this instead of merging it?

@tomvanzummeren
Copy link
Owner

I forgot to explain. My apologies.

I had a whole restructuring going on including several pull requests that needed to be merged. So some pull requests (including this one) I simply did by hand on master because it was easier for me.

So if you look in master right now (and release 1.1.0), it should be Carthage compatible but I didn't test it. You would greatly help me out if you would be so kind to test it for me.

Thanks in advance!

@tomvanzummeren
Copy link
Owner

Hmm.. now that I think of it, I only merged the Xcode projects, I did not add a shared framework target... If you would be so kind to add that as a pull request, I will merge it immediately!

@regexident
Copy link
Contributor Author

That's actually exactly what I did with this PR. Thus my question. 😉

(It's based on commit 8f1e1b3, which as of right now if one commit behind and should merge without conflicts.)

What I did in this PR:

  1. Renamed TZStackView demo app target to TZStackViewDemo.
  2. Added TZStackView shared framework target.
  3. Removed non-demo classes from demo target
  4. Linked demo target with framework.

@tomvanzummeren tomvanzummeren reopened this Sep 7, 2015
@tomvanzummeren
Copy link
Owner

I am so sorry, there were lots of pull requests of weeks old, including one that rearranged all directories in order to support Carthage. I didn't realise yours wasn't even a day old and closed it because I confused it with that other one. I see I can cleanly merge this one so I am going to do it right now. Sorry for the confusion and thanks for your help!

tomvanzummeren added a commit that referenced this pull request Sep 7, 2015
Added shared framework target to support Carthage.
@tomvanzummeren tomvanzummeren merged commit aaef1db into tomvanzummeren:master Sep 7, 2015
@tomvanzummeren
Copy link
Owner

Did it work? Does TZStackView now support Carthage?

@regexident
Copy link
Contributor Author

I am so sorry, there were lots of pull requests of weeks old, including one that rearranged all directories in order to support Carthage. […] Sorry for the confusion and thanks for your help!

No problem! I figured it'd be a confusion of some kind.

Did it work? Does TZStackView now support Carthage?

Looking good for me (as of aaef1db)! 👍 😍

To try it out yourself follow these simple steps:

  1. Install Carthage, if you haven't already.
  2. $ mkdir test.
  3. $ cd test
  4. $ echo 'github "tomvanzummeren/TZStackView" "aaef1db"' > 'Cartfile'
  5. $ carthage bootstrap

You should get something like this:

*** No Cartfile.resolved found, updating dependencies
*** Fetching TZStackView
*** Checking out TZStackView at "aaef1db47cedeebdbfcc3b6b23412924a2500e7f"
*** xcodebuild output can be found in /var/folders/pc/2nfs9w4n2p5gr4r22cqnt5jcsh_nv5/T/carthage-xcodebuild.YVa7uO.log
*** Building scheme "TZStackView" in TZStackView.xcodeproj

…and find a directory Carthage added to test with subdirectories Build and Checkout containing your artifacts.

Thanks a lot for your work, Tom! We owe you one. 🍺

@tomvanzummeren
Copy link
Owner

You're welcome! And thank YOU!

@regexident regexident deleted the framework branch September 8, 2015 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants