-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shared framework target to support Carthage. #33
Conversation
Any particular reason for closing this instead of merging it? |
I forgot to explain. My apologies. I had a whole restructuring going on including several pull requests that needed to be merged. So some pull requests (including this one) I simply did by hand on master because it was easier for me. So if you look in master right now (and release 1.1.0), it should be Carthage compatible but I didn't test it. You would greatly help me out if you would be so kind to test it for me. Thanks in advance! |
Hmm.. now that I think of it, I only merged the Xcode projects, I did not add a shared framework target... If you would be so kind to add that as a pull request, I will merge it immediately! |
That's actually exactly what I did with this PR. Thus my question. 😉 (It's based on commit 8f1e1b3, which as of right now if one commit behind and should merge without conflicts.) What I did in this PR:
|
I am so sorry, there were lots of pull requests of weeks old, including one that rearranged all directories in order to support Carthage. I didn't realise yours wasn't even a day old and closed it because I confused it with that other one. I see I can cleanly merge this one so I am going to do it right now. Sorry for the confusion and thanks for your help! |
Added shared framework target to support Carthage.
Did it work? Does TZStackView now support Carthage? |
No problem! I figured it'd be a confusion of some kind.
Looking good for me (as of aaef1db)! 👍 😍 To try it out yourself follow these simple steps:
You should get something like this:
…and find a directory Thanks a lot for your work, Tom! We owe you one. 🍺 |
You're welcome! And thank YOU! |
Follow-up for issue #19.
Carthage needs to find the xcodeproj and a shared framework target.
As such it is impedimental to have multiple xcodeproj files and subprojects, especially when the xcodeproj file has a different name than the Project and no shared framework.