fix: disallow URL unsafe inputs #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tompave is this change something you'd consider accepting? Or any alternate ideas for approaching this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #36
My team ran onto this exact issue by accident—someone accidentally created a group name with URL reserved chars (specifically
/) in it, and because theurl_safefunction does not escape these, it winds up creating a bogus URL in the template.In my ideal world the solution in the linked PR above would be accepted, but given the conversation on that PR, that seems like it's not going to happen, so this at least validates that unsafe inputs can't be used to create a group or flag name.