Skip to content

fix: const dectection. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix: const dectection. #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions checks/argument.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,18 @@ package checks
import (
"go/ast"
"go/token"
"strconv"
"sync"

"golang.org/x/tools/go/analysis"

config "github.com/tommy-muehle/go-mnd/v2/config"
"github.com/tommy-muehle/go-mnd/v2/config"
)

const ArgumentCheck = "argument"

// constantDefinitions is used to save lines (by number) which contain a constant definition.
var constantDefinitions = map[int]bool{}
var constantDefinitions = map[string]bool{}
var mu sync.RWMutex

type ArgumentAnalyzer struct {
Expand All @@ -40,17 +41,21 @@ func (a *ArgumentAnalyzer) Check(n ast.Node) {
case *ast.CallExpr:
a.checkCallExpr(expr)
case *ast.GenDecl:
if expr.Tok.String() == "const" {
if expr.Tok == token.CONST {
pos := a.pass.Fset.Position(expr.TokPos)

mu.Lock()
constantDefinitions[a.pass.Fset.Position(expr.TokPos).Line] = true
constantDefinitions[pos.Filename+":"+strconv.Itoa(pos.Line)] = true
mu.Unlock()
}
}
}

func (a *ArgumentAnalyzer) checkCallExpr(expr *ast.CallExpr) {
pos := a.pass.Fset.Position(expr.Pos())

mu.RLock()
ok := constantDefinitions[a.pass.Fset.Position(expr.Pos()).Line]
ok := constantDefinitions[pos.Filename+":"+strconv.Itoa(pos.Line)]
mu.RUnlock()

if ok {
Expand Down