Frequently used #55
Frequently used #55
Conversation
…emojis would always be in top
|
Thanks for your work here, I'll take a pass at properly reviewing this within the next few days. |
package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "devDependencies": { | |||
| "babel-cli": "^6.7.5", | |||
| "babel-eslint": "^7.1.1", | |||
| "babel-plugin-transform-object-rest-spread": "6.22.0", | |||
There was a problem hiding this comment.
This devDependency shouldn't be needed - the object-rest-spread transform is included in the stage 3 preset, which is a transitive dependency of the stage 0 preset already in place. Does the build complete without this new dependency?
There was a problem hiding this comment.
I get this error without the dependency:
Error: Cannot find module 'babel-plugin-transform-object-rest-spread' (While processing preset: "[path...]/emojione-picker/node_modules/babel-preset-stage-0/lib/index.js")
Am I doing something else wrong?
There was a problem hiding this comment.
I'm not sure - I don't see that error locally with node 7.5.0 and npm 4.2.0. Maybe try wiping out node_modules and reinstalling? If that doesn't work please post your node/npm versions.
|
You can Increase the number of emoji that are rendered in each row to 9 in createRowsSelector to match the added category in the header. |
|
Now that #54 is merged in, could you update this branch from master? I'm hitting that error when running the preview. |
|
Fixed things @ahutchings mentioned in the thread (removed dependency, merged from master, render one more emoji in each row). |
Add frequently used functionality, requested in #6.
Note this pull request is dependent on #54