Merged
Conversation
This offers about a 3% parse improvement which doesn't seem worth the complexity of directly exposing.
This offers about a 3% parse improvement which doesn't seem worth the complexity of directly exposing.
With the shift from `toml_edit` to `toml`, the complexity for this isn't needed anymore as performance is less of a priorty.
Pull Request Test Coverage Report for Build 15935797184Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These features are not pulling there weight, only reducing parse time by about 3%. I left them on
toml_parsefor now because the API is lower level and someone may care. By doing this we remove risk and simplify the code. This is especially helpful fortoml_editbecause performance will matter less withtomlcovering more use cases.Closes #949
BREAKING CHANGE: Removed
toml_editperffeatureBREAKING CHANGE: Replaced
InternalStringwithString