feat(toml)!: Update parser by using toml_edit
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`toml_edit::de::Deserializer` got a `FromStr` so callers could bypass the `despan` calls for extra performance. BREAKING CHANGES: - `Deserializer` now only handles documents, use `ValueDeserializer` otherwise - `from_slice` removed
This was referenced Jan 18, 2023
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 18, 2023
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 18, 2023
PR toml-rs#457 changed out the parser to `toml_edit` which had a lot of span improvements done, including addressing this. Fixes toml-rs#425
This was referenced Jan 18, 2023
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 19, 2023
With toml-rs#457, we've started to make a harder distinction between documents and values in `de`. We are looking to do similar for `ser` which requires us to do this for `Table`/`Value` as well. Fixes toml-rs#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toml_edit::de::Deserializergot aFromStrso callers could bypass thedespancalls for extra performance.This is a step towards #340
Tried to capture regressions in errors in
toml_editerror regression compared totoml: no message for\r#450toml_editerror regression compared totoml: string parse errors don't tell user what went wrong #451toml_editerror regression compared totoml: missing value could use more specific error #452toml_editerror regression compared totoml: missing key #453toml_editerror regression compared totoml: wrong string type for keys #454toml_editerror regression compared totoml: unterminated string #455toml_editerror regression compared totoml: redefinition of table #456BREAKING CHANGES:
Deserializernow only handles documents, useValueDeserializerotherwisefrom_sliceremoved