Skip to content

Revert "fix(toml): Track dotted key for spans"#1119

Merged
epage merged 1 commit intotoml-rs:mainfrom
epage:revert
Mar 6, 2026
Merged

Revert "fix(toml): Track dotted key for spans"#1119
epage merged 1 commit intotoml-rs:mainfrom
epage:revert

Conversation

@epage
Copy link
Member

@epage epage commented Mar 6, 2026

This reverts commit 87461d8.

For duplicate key errors, it was somewhat justifiable. When looking at errors in practice, it is not:

 [ERROR] invalid character `.` in profile name: `.release-lto`, allowed characters are letters, numbers, underscore, a
nd hyphen
- --> Cargo.toml:8:26
+ --> Cargo.toml:8:18
   |
 8 |                 [profile.'.release-lto']
-  |                          ^^^^^^^^^^^^^^
+  |                  ^^^^^^^^^^^^^^^^^^^^^^

This reverts commit 87461d8.

For duplicate key errors, it was somewhat justifiable.
When looking at errors in practice, it is not:
```
 [ERROR] invalid character `.` in profile name: `.release-lto`, allowed characters are letters, numbers, underscore, a
nd hyphen
- --> Cargo.toml:8:26
+ --> Cargo.toml:8:18
   |
 8 |                 [profile.'.release-lto']
-  |                          ^^^^^^^^^^^^^^
+  |                  ^^^^^^^^^^^^^^^^^^^^^^
```
@epage epage enabled auto-merge March 6, 2026 22:56
@epage epage disabled auto-merge March 6, 2026 22:56
@epage epage merged commit 2902954 into toml-rs:main Mar 6, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant