forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make the improper_ctypes lint more robust
It now checks extern fns in addition to foreign fns and checks `DefStruct` defs as well. There is room for improvement: for example, I believe that pointers should be safe in extern fn signatures regardless of the pointee's representation. The `FIXME` on `rust_begin_unwind_fmt` is because I don't think it should be, or needs to be, C ABI (cc @eddyb) and it takes a problematic `fmt::Arguments` structure by value. Fix rust-lang#20098, fix rust-lang#19834
- Loading branch information
1 parent
19f73b4
commit 5ec3ee9
Showing
4 changed files
with
67 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![deny(improper_ctypes)] | ||
|
||
#[repr(C)] | ||
pub struct Foo { | ||
_x: String | ||
} | ||
|
||
extern { | ||
pub fn bad(f: Foo); //~ ERROR found type without foreign-function-safe | ||
} | ||
|
||
fn main() { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters