Issue : Declaration of jsonSerialize() must be compatible #35 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hode soit valide, les signatures des méthodes doivent être identiques. Ici, la méthode jsonSerialize() de la classe BenjaminHirsh/NovaSlugField/slug doit avoir exactement la même signature que celle de la classe Laravel/Nova/Fields/Field. Pour résoudre cette erreur, il faut vérifier la déclaration de la méthode jsonSerialize() dans la classe BenjaminHirsh/NovaSlugField/slug et s'assurer qu'elle a la même signature que celle de la class parente Laravel/Nova/Fields/Field.
|
@tomhatzer Is there a chance that you can merge the pull request? |
tomhatzer
approved these changes
Dec 27, 2023
|
It's not my pull request but I need the same change and I thought maybe I can speed things up when I ping you directly 😄 |
|
@tomhatzer 🙏 please make a new release with that change - would really appreciate it |
|
@juergenZeindlinger done! |
|
Thank you so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the overload (or implementation of an interface) of a method to be valid, the signatures of the methods must be identical. Here, the jsonSerialize() method of the BenjaminHirsh/NovaSlugField/slug class must have the exact same signature as that of the Laravel/Nova/Fields/Field class.
To resolve this error, check the declaration of the jsonSerialize() method in the BenjaminHirsh/NovaSlugField/slug class and ensure that it has the same signature as that of the parent class Laravel/Nova/Fields/Field.