Fix for multiple spirals on map #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I implemented those changes in Thank you so much for contributing 💕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #177 , where Markers of spirals (markers with the exact same position) are duplicated to every other Spiral on the map. Currently, the only way to update a certain spiral is by pressing the cluster.
This also leads to the problem, that markers are displayed on the wrong position if there are multiple potential spiral clusters in the currently viewed area of the map.
With the fixes in this PR, it is possible to show the right markers on the spiral without having to press the cluster before.
Let me know if you need more information on the changes. :)