Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OverlayView): use ReactDOM.createPortal in React@^16 #895

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

urikphytech
Copy link
Contributor

PLEASE CHECK "Allow edits from maintainers"

help

FOLLOW "Conventional Commits Specification" FOR ALL COMMITS

https://conventionalcommits.org/

@maciekbb
Copy link

maciekbb commented Sep 2, 2018

Hello! Do you think it helps with performance issues described in #817?

I did a quick check and version from this PR seems to improve performance a lot. Time spent in OverlayView#getOffsetOverride went down from ~40% to ~3% when moving the map around in my specific use case.

@urikphytech
Copy link
Contributor Author

Great news!
Since this repo is not currently maintained I am using a fork of it which includes this fix in it.
https://github.com/urikphytech/react-google-maps

@owap
Copy link

owap commented Sep 11, 2018

@maciekbb I don't think this solves the issues with getOffsetOverride; we tried cloning this fork, as well as making the changes in this PR by hand, and neither result in any reduction in the time we spend in getOffsetOverride (between 50 and 60% for us).

Did you find another solution that solves the issue? If so, we'd love to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants