Skip to content

Table exists API add api version and accept json#55

Merged
tombuildsstuff merged 1 commit into
tombuildsstuff:masterfrom
magodo:table_exists_api
Jan 25, 2022
Merged

Table exists API add api version and accept json#55
tombuildsstuff merged 1 commit into
tombuildsstuff:masterfrom
magodo:table_exists_api

Conversation

@magodo

@magodo magodo commented Jan 25, 2022

Copy link
Copy Markdown
Contributor
  1. API version is necessary here to make the API accepts the AAD Auth
  2. The Accept json header is necessary here since otherwise the returned
    xml is in atom format, in which case the autorest will fail to parse.

This PR is related with hashicorp/terraform-provider-azurerm#15083

1. API version is necessary here to make the API accepts the AAD Auth
2. The Accept json header is necessary here since otherwise the returned
   xml is in atom format, in which case the autorest will fail to parse.

@tombuildsstuff tombuildsstuff left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v0.18.0 milestone Jan 25, 2022
@tombuildsstuff tombuildsstuff merged commit 8d5b2b4 into tombuildsstuff:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants