Skip to content

Commit

Permalink
hwmon: (sht3x) wait predefined limits loading complete before access
Browse files Browse the repository at this point in the history
An sht3x sensor include limits register which contains temperature
and humidity limit values. After a reset, pre-defined values are loaded
into that register. During the probe function, the driver reads the
limits register. However, if the reads are made too early, and the bus
is clocked at high frequencies (e.g. 100 kHz or more), the loading could be
not completed and the sensor returns a NACK which causes the probe to fail.
A delay of at least 500 us before the first read solves this issue.

Signed-off-by: Emiliano Ingrassia <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
  • Loading branch information
Emiliano Ingrassia authored and groeck committed Jan 12, 2018
1 parent b007640 commit abe6c3b
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/hwmon/sht3x.c
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,13 @@ static int sht3x_probe(struct i2c_client *client,
mutex_init(&data->i2c_lock);
mutex_init(&data->data_lock);

/*
* An attempt to read limits register too early
* causes a NACK response from the chip.
* Waiting for an empirical delay of 500 us solves the issue.
*/
usleep_range(500, 600);

ret = limits_update(data);
if (ret)
return ret;
Expand Down

0 comments on commit abe6c3b

Please sign in to comment.