Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/client/controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export function get_controller(renderable: Renderable): Controller {

export function invalidate(renderable: Renderable): void {
const controller = controllers.get(renderable)
assert(controller, 'the renderable has not been rendered')
controller._invalidate.forEach(invalidate => invalidate())
controller?._invalidate.forEach(invalidate => invalidate())
}

export function onMount(renderable: Renderable, callback: () => Cleanup): void {
Expand Down
20 changes: 1 addition & 19 deletions src/client/tests/renderable.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { html } from 'dhtml'
import { invalidate, onMount, onUnmount } from 'dhtml/client'
import { assert, assert_deep_eq, assert_eq, test } from '../../../scripts/test/test.ts'
import { assert_deep_eq, assert_eq, test } from '../../../scripts/test/test.ts'
import { setup } from './setup.ts'

test('renderables work correctly', () => {
Expand Down Expand Up @@ -474,24 +474,6 @@ test('invalidating an unmounted renderable does nothing', () => {
assert_eq(el.textContent, 'app2')
})

if (__DEV__) {
test('invalidate throws error when renderable has not been rendered', () => {
const app = {
render() {
return 'never rendered'
},
}

try {
invalidate(app)
assert(false, 'Expected error to be thrown')
} catch (error) {
assert(error instanceof Error)
assert(/the renderable has not been rendered/.test(error.message))
}
})
}

test('onMount called on already mounted renderable executes immediately', () => {
const { root } = setup()

Expand Down