Repository navigation
fix(lsp): stop logging empty workspace diagnostics - #2177
Merged
Merged
Conversation
- 対象ドキュメントがない場合は workspace diagnostic を早期終了 - 各LSPハンドラの info ログを設定適用後の実処理時だけ出力
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several handlers still log before their early returns, leaving the requested suppression incomplete.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request suppresses unnecessary Tombi LSP info logs when no diagnostic or file-processing target exists.
Changes:
- Add early returns for empty workspace diagnostics.
- Return empty diagnostic reports when no targets exist.
- Adjust logging in multiple LSP handlers.
File summaries
| File | Description |
|---|---|
crates/tombi-lsp/src/workspace_diagnostic.rs |
Early exit for empty diagnostic targets |
crates/tombi-lsp/src/handler/workspace_diagnostic.rs |
Early return for empty workspace diagnostics |
crates/tombi-lsp/src/handler/references.rs |
Adjust references logging |
crates/tombi-lsp/src/handler/hover.rs |
Adjust hover logging |
crates/tombi-lsp/src/handler/goto_type_definition.rs |
Adjust type-definition logging |
crates/tombi-lsp/src/handler/goto_definition.rs |
Adjust definition logging |
crates/tombi-lsp/src/handler/goto_declaration.rs |
Adjust declaration logging |
crates/tombi-lsp/src/handler/formatting.rs |
Adjust formatting logging |
crates/tombi-lsp/src/handler/document_link.rs |
Adjust document-link logging |
crates/tombi-lsp/src/handler/completion.rs |
Adjust completion logging |
crates/tombi-lsp/src/handler/code_action.rs |
Adjust code-action logging |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 9
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ya7010
changed the title
This was referenced Sep 14, 2026
jylenhof
pushed a commit
to jylenhof/mise-en-place-resources
that referenced
this pull request
Sep 15, 2026
Automated mise tool upgrades from local config. mise-managed tools: - `action-validator` - `actionlint` - `editorconfig-checker` - `ghalint` - `lychee` - `pinact` - `pipx:gh-action-pulse` - `prek` - `rumdl` - `shellcheck` - `shfmt` - `tombi` - `uv` - `yamlfmt` - `yamllint` - `zizmor` Command: `mise upgrade --bump --local action-validator actionlint editorconfig-checker ghalint lychee pinact pipx:gh-action-pulse prek rumdl shellcheck shfmt tombi uv yamlfmt yamllint zizmor` <details> <summary>Version changelog (5 tools)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `pinact` | `4.1.1` → `5.0.0` | `4.1.1` → `5.0.0` | | `prek` | `0.5.2` → `0.5.3` | `0.5.2` → `0.5.3` | | `rumdl` | `0.2.70` → `0.2.73` | `0.2.70` → `0.2.73` | | `tombi` | `1.5.4` → `1.5.5` | `1.5.4` → `1.5.5` | | `uv` | `0.12.12` → `0.12.13` | `0.12.12` → `0.12.13` | </details> <details> <summary>Release notes (5 tools)</summary> <details> <summary>pinact: `4.1.1` → `5.0.0` (suzuki-shunsuke/pinact)</summary> ### v5.0.0 suzuki-shunsuke/pinact@v4.1.1...v5.0.0 [Upgrade Guide](https://github.com/suzuki-shunsuke/pinact/blob/v5.0.0/docs/upgrade_guide/v5.md) ## 🤖 pinact is now AI friendly v5 is about coding agents. An agent that is asked about pinact, or that hits a pinact error in CI, has until now had to answer from its training data, from the source code, or from whichever version of the website it happened to land on. v5 gives it three things so that it answers from the pinact that is actually installed: #1708 An Agent Skill #1708 `pinact docs`: the documentation, embedded in the binary #1705 `pinact json-schema`: the JSON Schema of the configuration file, embedded in the binary ### An Agent Skill ```sh gh skill install suzuki-shunsuke/pinact pinact ``` The skill carries no documentation of its own, deliberately. It is installed separately from the binary, so anything copied into it would go stale, and an agent would confidently describe a flag or an error code of a version that isn't the one on the machine. Instead the skill tells the agent to run `pinact docs list` and `pinact docs show <name>` before answering, so the answer always comes from the installed pinact and the skill and the binary can never disagree about a version. It adds only the few things an agent gets wrong unless it is told: that `pinact run` edits files and `--check` is the way to look without touching them, that `--update` changes which version a workflow uses, and that the exit codes 1 and 2 are findings rather than pinact failing. ### `pinact docs` ```console $ pinact docs list # the name and the description of every document, as JSON $ pinact docs show config # one document $ pinact docs show codes/005 ``` The documents are embedded in the binary, so there is nothing to fetch. An agent doesn't need network access to read them, doesn't have to guess which branch or tag of the repository to read, and cannot land on the documentation of a versi… (truncated) </details> <details> <summary>prek: `0.5.2` → `0.5.3` (j178/prek)</summary> ### v0.5.3 ## Release Notes Released on 2026-09-13. ### Enhancements - Add PEP 740 attestations for PyPI releases ([#2705](j178/prek#2705)) - Add a `check-jsonc` builtin hook ([#2682](j178/prek#2682)) - Allow disabling automatic uv installation ([#2702](j178/prek#2702)) ### Bug fixes - Fix Julia additional dependency specifiers ([#2703](j178/prek#2703)) - Update `granit-parser` to fix YAML flow indentation ([#2707](j178/prek#2707)) ### Contributors - @clbarnes - @j178 - @tisonkun ## Install prek 0.5.3 ### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://github.com/j178/prek/releases/download/v0.5.3/prek-installer.sh | sh ``` ### Install prebuilt binaries via powershell script ```sh powershell -ExecutionPolicy Bypass -c "irm https://github.com/j178/prek/releases/download/v0.5.3/prek-installer.ps1 | iex" ``` ### Install prebuilt binaries via Homebrew ```sh brew install prek ``` ## Download prek 0.5.3 | File | Platform | Checksum | |--------|----------|----------| | [prek-aarch64-apple-darwin.tar.gz](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-apple-darwin.tar.gz) | Apple Silicon macOS | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-apple-darwin.tar.gz.sha256) | | [prek-x86_64-apple-darwin.tar.gz](https://github.com/j178/prek/releases/download/v0.5.3/prek-x86_64-apple-darwin.tar.gz) | Intel macOS | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-x86_64-apple-darwin.tar.gz.sha256) | | [prek-aarch64-pc-windows-msvc.zip](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-pc-windows-msvc.zip) | ARM64 Windows | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-pc-windows-msvc.zip.sha256) | | [prek-x86_64-pc-windows-msvc.zip](https://github.com/j178/prek/releases/downloa… (truncated) </details> <details> <summary>rumdl: `0.2.70` → `0.2.73` (rvben/rumdl)</summary> ### v0.2.71 ### Fixed - **MD034**: do not report the tail of a schemed URI as a bare email ([a8df862](rvben/rumdl@a8df862)) - **lsp**: write the mailto scheme when converting a bare email to a link ([600e229](rvben/rumdl@600e229)) - **config**: measure suggestion distance in characters, not bytes ([eabdf80](rvben/rumdl@eabdf80)) - **MD034**: emit a link, not an autolink, when fixing bare URLs in MDX ([98a6255](rvben/rumdl@98a6255)) - **config**: suggestion panics on multibyte characters ([dd88a4a](rvben/rumdl@dd88a4a)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.71-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.71-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.71-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.71-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.71/rumdl-v0.2.71-aarch64-unknown-linux-musl.tar.gz) | Linux ARM64 (musl) | [checksum](https://git… (truncated) ### v0.2.72 ### Added - **MD090**: add rule flagging horizontal rules directly before headings ([09dcae5](rvben/rumdl@09dcae5)) ### Fixed - **MD013**: end a sentence after a closing marker run of any shape ([e63206c](rvben/rumdl@e63206c)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz) | Linux ARM64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.72-x86_64-apple-darwin.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-apple-darwin.tar.gz) | macOS x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-apple-darwin.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-apple-darwin.tar.gz](https://github.com/rvben/rumdl/… (truncated) ### v0.2.73 ### Fixed - **MD022,MD031,MD032,MD058**: count a comment-only line as a blank line ([b394e30](rvben/rumdl@b394e30)) - **MD057**: stop requiring index.md for directory links in filesystem mode ([c04ae4e](rvben/rumdl@c04ae4e)) - **MD051**: validate fragments in repository-absolute cross-file links ([ead5f39](rvben/rumdl@ead5f39)) - **parser**: stop reading headings inside blocks whose body is not Markdown ([59958b1](rvben/rumdl@59958b1)) - **MD077**: carry a code block's interior indentation when reindenting its fence ([00c578d](rvben/rumdl@00c578d)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.73-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-musl.tar.gz) | L… (truncated) </details> <details> <summary>tombi: `1.5.4` → `1.5.5` (tombi-toml/tombi)</summary> ### v1.5.5 <!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: tombi-toml/tombi@v1.5.4...v1.5.5 </details> <details> <summary>uv: `0.12.12` → `0.12.13` (astral-sh/uv)</summary> ### 0.12.13 ## Release Notes Released on 2026-09-10. ### Python - Add GraalPy 3.13.0 ([#21431](astral-sh/uv#21431)) ### Enhancements - Verify hashes when downloading PEP 658 metadata sidecars ([#21563](astral-sh/uv#21563)) ### Preview features - Respect `ty` exclusions when `uv check` automatically selects members of a virtual workspace ([#21555](astral-sh/uv#21555)) ### Performance - Avoid full wheel downloads during resolution by reusing supported hashes from direct URL fragments when metadata is available separately ([#21279](astral-sh/uv#21279)) ### Bug fixes - Edit Windows entry-point launcher resources in memory to support Nano Server and reduce antivirus contention ([#18713](astral-sh/uv#18713)) - Prefer `core-metadata` over legacy aliases in JSON index responses ([#21563](astral-sh/uv#21563)) ## Install uv 0.12.13 ### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://releases.astral.sh/github/uv/releases/download/0.12.13/uv-installer.sh | sh ``` ### Install prebuilt binaries via powershell script ```sh powershell -ExecutionPolicy Bypass -c "irm https://releases.astral.sh/github/uv/releases/download/0.12.13/uv-installer.ps1 | iex" ``` ## Download uv 0.12.13 | File | Platform | Checksum | |--------|----------|----------| | [uv-aarch64-apple-darwin.tar.gz](https://releases.astral.sh/github/uv/releases/download/0.12.13/uv-aarch64-apple-darwin.tar.gz) | Apple Silicon macOS | [checksum](https://releases.astral.sh/github/uv/releases/download/0.12.13/uv-aarch64-apple-darwin.tar.gz.sha256) | | [uv-x86_64-apple-darwin.tar.gz](https://releases.astral.sh/github/uv/releases/download/0.12.13/uv-x86_64-apple-darwin.tar.gz) | Intel macOS | [checksum](https://releases.astral.sh/github/uv/releases/download/0.12.13/uv-x86_64-apple-darwin.tar.gz.sha256) | | [uv-aarch64-pc… (truncated) </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jylenhof
pushed a commit
to jylenhof/mise-update-tool
that referenced
this pull request
Sep 15, 2026
Automated mise tool upgrades from local config. mise-managed tools: - `action-validator` - `actionlint` - `aube` - `editorconfig-checker` - `ghalint` - `pinact` - `pipx:gh-action-pulse` - `prek` - `rumdl` - `shellcheck` - `shfmt` - `tombi` - `uv` - `yamlfmt` - `yamllint` - `zizmor` Command: `mise upgrade --bump --local action-validator actionlint aube editorconfig-checker ghalint pinact pipx:gh-action-pulse prek rumdl shellcheck shfmt tombi uv yamlfmt yamllint zizmor` <details> <summary>Version changelog (4 tools)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `pinact` | `4.1.1` → `5.0.0` | `4.1.1` → `5.0.0` | | `prek` | `0.5.2` → `0.5.3` | `0.5.2` → `0.5.3` | | `rumdl` | `0.2.71` → `0.2.73` | `0.2.71` → `0.2.73` | | `tombi` | `1.5.4` → `1.5.5` | `1.5.4` → `1.5.5` | </details> <details> <summary>Release notes (4 tools)</summary> <details> <summary>pinact: `4.1.1` → `5.0.0` (suzuki-shunsuke/pinact)</summary> ### v5.0.0 suzuki-shunsuke/pinact@v4.1.1...v5.0.0 [Upgrade Guide](https://github.com/suzuki-shunsuke/pinact/blob/v5.0.0/docs/upgrade_guide/v5.md) ## 🤖 pinact is now AI friendly v5 is about coding agents. An agent that is asked about pinact, or that hits a pinact error in CI, has until now had to answer from its training data, from the source code, or from whichever version of the website it happened to land on. v5 gives it three things so that it answers from the pinact that is actually installed: #1708 An Agent Skill #1708 `pinact docs`: the documentation, embedded in the binary #1705 `pinact json-schema`: the JSON Schema of the configuration file, embedded in the binary ### An Agent Skill ```sh gh skill install suzuki-shunsuke/pinact pinact ``` The skill carries no documentation of its own, deliberately. It is installed separately from the binary, so anything copied into it would go stale, and an agent would confidently describe a flag or an error code of a version that isn't the one on the machine. Instead the skill tells the agent to run `pinact docs list` and `pinact docs show <name>` before answering, so the answer always comes from the installed pinact and the skill and the binary can never disagree about a version. It adds only the few things an agent gets wrong unless it is told: that `pinact run` edits files and `--check` is the way to look without touching them, that `--update` changes which version a workflow uses, and that the exit codes 1 and 2 are findings rather than pinact failing. ### `pinact docs` ```console $ pinact docs list # the name and the description of every document, as JSON $ pinact docs show config # one document $ pinact docs show codes/005 ``` The documents are embedded in the binary, so there is nothing to fetch. An agent doesn't need network access to read them, doesn't have to guess which branch or tag of the repository to read, and cannot land on the documentation of a versi… (truncated) </details> <details> <summary>prek: `0.5.2` → `0.5.3` (j178/prek)</summary> ### v0.5.3 ## Release Notes Released on 2026-09-13. ### Enhancements - Add PEP 740 attestations for PyPI releases ([#2705](j178/prek#2705)) - Add a `check-jsonc` builtin hook ([#2682](j178/prek#2682)) - Allow disabling automatic uv installation ([#2702](j178/prek#2702)) ### Bug fixes - Fix Julia additional dependency specifiers ([#2703](j178/prek#2703)) - Update `granit-parser` to fix YAML flow indentation ([#2707](j178/prek#2707)) ### Contributors - @clbarnes - @j178 - @tisonkun ## Install prek 0.5.3 ### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://github.com/j178/prek/releases/download/v0.5.3/prek-installer.sh | sh ``` ### Install prebuilt binaries via powershell script ```sh powershell -ExecutionPolicy Bypass -c "irm https://github.com/j178/prek/releases/download/v0.5.3/prek-installer.ps1 | iex" ``` ### Install prebuilt binaries via Homebrew ```sh brew install prek ``` ## Download prek 0.5.3 | File | Platform | Checksum | |--------|----------|----------| | [prek-aarch64-apple-darwin.tar.gz](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-apple-darwin.tar.gz) | Apple Silicon macOS | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-apple-darwin.tar.gz.sha256) | | [prek-x86_64-apple-darwin.tar.gz](https://github.com/j178/prek/releases/download/v0.5.3/prek-x86_64-apple-darwin.tar.gz) | Intel macOS | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-x86_64-apple-darwin.tar.gz.sha256) | | [prek-aarch64-pc-windows-msvc.zip](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-pc-windows-msvc.zip) | ARM64 Windows | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-pc-windows-msvc.zip.sha256) | | [prek-x86_64-pc-windows-msvc.zip](https://github.com/j178/prek/releases/downloa… (truncated) </details> <details> <summary>rumdl: `0.2.71` → `0.2.73` (rvben/rumdl)</summary> ### v0.2.72 ### Added - **MD090**: add rule flagging horizontal rules directly before headings ([09dcae5](rvben/rumdl@09dcae5)) ### Fixed - **MD013**: end a sentence after a closing marker run of any shape ([e63206c](rvben/rumdl@e63206c)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz) | Linux ARM64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.72-x86_64-apple-darwin.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-apple-darwin.tar.gz) | macOS x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-apple-darwin.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-apple-darwin.tar.gz](https://github.com/rvben/rumdl/… (truncated) ### v0.2.73 ### Fixed - **MD022,MD031,MD032,MD058**: count a comment-only line as a blank line ([b394e30](rvben/rumdl@b394e30)) - **MD057**: stop requiring index.md for directory links in filesystem mode ([c04ae4e](rvben/rumdl@c04ae4e)) - **MD051**: validate fragments in repository-absolute cross-file links ([ead5f39](rvben/rumdl@ead5f39)) - **parser**: stop reading headings inside blocks whose body is not Markdown ([59958b1](rvben/rumdl@59958b1)) - **MD077**: carry a code block's interior indentation when reindenting its fence ([00c578d](rvben/rumdl@00c578d)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.73-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-musl.tar.gz) | L… (truncated) </details> <details> <summary>tombi: `1.5.4` → `1.5.5` (tombi-toml/tombi)</summary> ### v1.5.5 <!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: tombi-toml/tombi@v1.5.4...v1.5.5 </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jylenhof
pushed a commit
to jylenhof/gh-action-pulse
that referenced
this pull request
Sep 16, 2026
Automated mise tool upgrades from local config. mise-managed tools: - `tombi` Command: `mise upgrade --bump --local tombi` <details> <summary>Version changelog (tombi)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `tombi` | `1.5.4` → `1.5.5` | `1.5.4` → `1.5.5` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>tombi: `1.5.4` → `1.5.5` (tombi-toml/tombi)</summary> ### v1.5.5 <!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: tombi-toml/tombi@v1.5.4...v1.5.5 </details> </details> Modified files: - `.mise.toml`
jylenhof
pushed a commit
to jylenhof/gh-action-pulse
that referenced
this pull request
Sep 16, 2026
Automated mise tool upgrades from local config. mise-managed tools: - `tombi` Command: `mise upgrade --bump --local tombi` <details> <summary>Version changelog (tombi)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `tombi` | `1.5.4` → `1.5.5` | `1.5.4` → `1.5.5` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>tombi: `1.5.4` → `1.5.5` (tombi-toml/tombi)</summary> ### v1.5.5 <!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: tombi-toml/tombi@v1.5.4...v1.5.5 </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jylenhof
pushed a commit
to jylenhof/github-actions-resources
that referenced
this pull request
Sep 16, 2026
Automated mise tool upgrades from local config. mise-managed tools: - `action-validator` - `actionlint` - `editorconfig-checker` - `ghalint` - `lychee` - `pinact` - `pipx:gh-action-pulse` - `prek` - `rumdl` - `shellcheck` - `shfmt` - `tombi` - `uv` - `yamlfmt` - `yamllint` - `zizmor` Command: `mise upgrade --bump --local action-validator actionlint editorconfig-checker ghalint lychee pinact pipx:gh-action-pulse prek rumdl shellcheck shfmt tombi uv yamlfmt yamllint zizmor` <details> <summary>Version changelog (4 tools)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `pinact` | `4.1.1` → `5.0.0` | `4.1.1` → `5.0.0` | | `prek` | `0.5.2` → `0.5.3` | `0.5.2` → `0.5.3` | | `rumdl` | `0.2.71` → `0.2.73` | `0.2.71` → `0.2.73` | | `tombi` | `1.5.4` → `1.5.5` | `1.5.4` → `1.5.5` | </details> <details> <summary>Release notes (4 tools)</summary> <details> <summary>pinact: `4.1.1` → `5.0.0` (suzuki-shunsuke/pinact)</summary> ### v5.0.0 suzuki-shunsuke/pinact@v4.1.1...v5.0.0 [Upgrade Guide](https://github.com/suzuki-shunsuke/pinact/blob/v5.0.0/docs/upgrade_guide/v5.md) ## 🤖 pinact is now AI friendly v5 is about coding agents. An agent that is asked about pinact, or that hits a pinact error in CI, has until now had to answer from its training data, from the source code, or from whichever version of the website it happened to land on. v5 gives it three things so that it answers from the pinact that is actually installed: #1708 An Agent Skill #1708 `pinact docs`: the documentation, embedded in the binary #1705 `pinact json-schema`: the JSON Schema of the configuration file, embedded in the binary ### An Agent Skill ```sh gh skill install suzuki-shunsuke/pinact pinact ``` The skill carries no documentation of its own, deliberately. It is installed separately from the binary, so anything copied into it would go stale, and an agent would confidently describe a flag or an error code of a version that isn't the one on the machine. Instead the skill tells the agent to run `pinact docs list` and `pinact docs show <name>` before answering, so the answer always comes from the installed pinact and the skill and the binary can never disagree about a version. It adds only the few things an agent gets wrong unless it is told: that `pinact run` edits files and `--check` is the way to look without touching them, that `--update` changes which version a workflow uses, and that the exit codes 1 and 2 are findings rather than pinact failing. ### `pinact docs` ```console $ pinact docs list # the name and the description of every document, as JSON $ pinact docs show config # one document $ pinact docs show codes/005 ``` The documents are embedded in the binary, so there is nothing to fetch. An agent doesn't need network access to read them, doesn't have to guess which branch or tag of the repository to read, and cannot land on the documentation of a versi… (truncated) </details> <details> <summary>prek: `0.5.2` → `0.5.3` (j178/prek)</summary> ### v0.5.3 ## Release Notes Released on 2026-09-13. ### Enhancements - Add PEP 740 attestations for PyPI releases ([#2705](j178/prek#2705)) - Add a `check-jsonc` builtin hook ([#2682](j178/prek#2682)) - Allow disabling automatic uv installation ([#2702](j178/prek#2702)) ### Bug fixes - Fix Julia additional dependency specifiers ([#2703](j178/prek#2703)) - Update `granit-parser` to fix YAML flow indentation ([#2707](j178/prek#2707)) ### Contributors - @clbarnes - @j178 - @tisonkun ## Install prek 0.5.3 ### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://github.com/j178/prek/releases/download/v0.5.3/prek-installer.sh | sh ``` ### Install prebuilt binaries via powershell script ```sh powershell -ExecutionPolicy Bypass -c "irm https://github.com/j178/prek/releases/download/v0.5.3/prek-installer.ps1 | iex" ``` ### Install prebuilt binaries via Homebrew ```sh brew install prek ``` ## Download prek 0.5.3 | File | Platform | Checksum | |--------|----------|----------| | [prek-aarch64-apple-darwin.tar.gz](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-apple-darwin.tar.gz) | Apple Silicon macOS | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-apple-darwin.tar.gz.sha256) | | [prek-x86_64-apple-darwin.tar.gz](https://github.com/j178/prek/releases/download/v0.5.3/prek-x86_64-apple-darwin.tar.gz) | Intel macOS | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-x86_64-apple-darwin.tar.gz.sha256) | | [prek-aarch64-pc-windows-msvc.zip](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-pc-windows-msvc.zip) | ARM64 Windows | [checksum](https://github.com/j178/prek/releases/download/v0.5.3/prek-aarch64-pc-windows-msvc.zip.sha256) | | [prek-x86_64-pc-windows-msvc.zip](https://github.com/j178/prek/releases/downloa… (truncated) </details> <details> <summary>rumdl: `0.2.71` → `0.2.73` (rvben/rumdl)</summary> ### v0.2.72 ### Added - **MD090**: add rule flagging horizontal rules directly before headings ([09dcae5](rvben/rumdl@09dcae5)) ### Fixed - **MD013**: end a sentence after a closing marker run of any shape ([e63206c](rvben/rumdl@e63206c)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz) | Linux ARM64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-aarch64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.72-x86_64-apple-darwin.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-apple-darwin.tar.gz) | macOS x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.72/rumdl-v0.2.72-x86_64-apple-darwin.tar.gz.sha256) | | [rumdl-v0.2.72-aarch64-apple-darwin.tar.gz](https://github.com/rvben/rumdl/… (truncated) ### v0.2.73 ### Fixed - **MD022,MD031,MD032,MD058**: count a comment-only line as a blank line ([b394e30](rvben/rumdl@b394e30)) - **MD057**: stop requiring index.md for directory links in filesystem mode ([c04ae4e](rvben/rumdl@c04ae4e)) - **MD051**: validate fragments in repository-absolute cross-file links ([ead5f39](rvben/rumdl@ead5f39)) - **parser**: stop reading headings inside blocks whose body is not Markdown ([59958b1](rvben/rumdl@59958b1)) - **MD077**: carry a code block's interior indentation when reindenting its fence ([00c578d](rvben/rumdl@00c578d)) ## Downloads | File | Platform | Checksum | |------|----------|----------| | [rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz) | Linux x86_64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz) | Linux x86_64 (musl) | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-x86_64-unknown-linux-musl.tar.gz.sha256) | | [rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz) | Linux ARM64 | [checksum](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-gnu.tar.gz.sha256) | | [rumdl-v0.2.73-aarch64-unknown-linux-musl.tar.gz](https://github.com/rvben/rumdl/releases/download/v0.2.73/rumdl-v0.2.73-aarch64-unknown-linux-musl.tar.gz) | L… (truncated) </details> <details> <summary>tombi: `1.5.4` → `1.5.5` (tombi-toml/tombi)</summary> ### v1.5.5 <!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: tombi-toml/tombi@v1.5.4...v1.5.5 </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Sep 16, 2026
jylenhof
pushed a commit
to jylenhof/mise-en-place-tips
that referenced
this pull request
Sep 16, 2026
Automated mise tool upgrades from local config. mise-managed tools: - `tombi` Command: `mise upgrade --bump --local tombi` <details> <summary>Version changelog (tombi)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `tombi` | `1.5.4` → `1.5.5` | `1.5.4` → `1.5.5` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>tombi: `1.5.4` → `1.5.5` (tombi-toml/tombi)</summary> ### v1.5.5 <!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: tombi-toml/tombi@v1.5.4...v1.5.5 </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
tombi 1.5.5 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre><!-- Release notes generated using configuration in .github/release.yml at v1.5.5 --> ## What's Changed ### 🛠️ Other Changes * fix(lsp): stop logging empty workspace diagnostics by @ya7010 in tombi-toml/tombi#2177 * fix(vscode): persist status bar item visibility by @ya7010 in tombi-toml/tombi#2178 * fix(lsp): skip workspace diagnostics when lsp.diagnostic is disabled by @ya7010 in tombi-toml/tombi#2179 **Full Changelog**: https://github.com/tombi-toml/tombi/compare/v1.5.4...v1.5.5</pre> <p>View the full release notes at <a href="https://github.com/tombi-toml/tombi/releases/tag/v1.5.5">https://github.com/tombi-toml/tombi/releases/tag/v1.5.5</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!20105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Tombi language server logged what looked like repeated workspace diagnostic runs even when there was no file to process. From a user's point of view,
handle_workspace_diagnostickept showing up roughly every 2 seconds while nothing was happening, which reads as wasted work or a performance problem.Solution
Return early, without doing anything, when there is nothing to diagnose. Empty workspace diagnostics no longer emit a log; a diagnostic log is recorded only when there is something to actually process.
Along with that, the code action, completion, hover, formatting, and definition LSP handlers no longer emit an
infolog when they return early for an out-of-scope file or configuration.Fixes #2176