src/fut_with_diag: Reduce overhead when logging disabled#1
Merged
tomaka merged 1 commit intotomaka:masterfrom Jan 29, 2020
Merged
src/fut_with_diag: Reduce overhead when logging disabled#1tomaka merged 1 commit intotomaka:masterfrom
tomaka merged 1 commit intotomaka:masterfrom
Conversation
`DiagnoeFuture::poll` either just polls the underlying future when logging is disabled, or records the start time, polls the future, records the end time, logs the information and then returns the poll outcome. In the former case where logging is disabled, there is no reason to record start and end time, given that `log_poll` becomes a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiagnoeFuture::polleither just polls the underlying future whenlogging is disabled, or records the start time, polls the future,
records the end time, logs the information and then returns the poll
outcome.
In the former case where logging is disabled, there is no reason to
record start and end time, given that
log_pollbecomes a no-op.This might just be optimized away by the compiler anyways. But given that it simplifies the code with an early return as well, I think it is worth doing.
Related to paritytech/substrate#4752.