[WIP] Listening Rooms #128

teo · 2012-11-12T21:37:35Z

They are rooms. You can listen to music in them. What's there not to like?

Seriously though, this is an extension of the "listen along" concept. Still WiP, but the idea is for listeners to be able to see what's upcoming and track history, and submit suggestions. Listening Rooms also appear superficially like playlists, but they are not persistent, and the track operations are very different.
This Listening Rooms concept is not like Soundrop, it is not massive democratic music listening, but rather the idea is to allow a person to host a party, and guests to occasionally chip in.

Ramblurr · 2012-11-14T15:08:35Z

My holy god. This feature is finally coming! Huzzah! (pardon cheers from peanut gallery)

teo · 2012-11-20T18:42:36Z

Since 367649e which I just pushed, all core Listening Rooms operations should work. One can start a room and become DJ, and others can join in and become listeners. Aside from a few crashes here and there, it is usable, though not quite ready for merging.
Suggestions are not implemented yet.
For the next few days, possibly more than a week, I will not be committing major changes to this branch, focusing instead on writing the thesis document based on this work. After that, but still before mid-December, I plan on finishing with the suggestions feature.
Since this heap of code won't be changing much, feel free to start reviewing.

lfranchi · 2012-11-20T19:34:26Z

Awesome! Do you want feedback from testing as well? Or would you rather wait for your December changes?

lfranchi · 2012-11-22T04:25:59Z

src/CMakeLists.txt

@@ -61,6 +61,8 @@ SET( tomahawkSourcesGui ${tomahawkSourcesGui}
     sourcetree/items/PlaylistItems.cpp
     sourcetree/items/CategoryItems.cpp
     sourcetree/items/GenericPageItems.cpp
+     sourcetree/items/ListeningRoomItem.cpp
+     sourcetree/items/ListeningRoomsCategoryItem.cpp


Super nitpick: one is plural one is not :)

lfranchi · 2012-11-22T05:00:44Z

One thing just came to mind---since a listening room's default playlist interface is just the source playlist interface, we probably want to change the default listen along behaviour for listening rooms to be "locked on"---that is, if a DJ skips a song, listeners should immediately skip too, unlike listening along. Being synchronized in the same room is more important.

lfranchi · 2012-11-22T19:08:57Z

src/libtomahawk/ListeningRoomModel.cpp

+
+
+void
+ListeningRoomModel::endRoomChanges()


I wonder if we can somehow share the add/remove/move logic between Playlist and ListeningRoom. I added the m_savedInsertPos + move/etc logic to handle spotify syncing (we need incremental changes not just full revisions), but it seems fragile now to have to maintain this tricky code in two places.

This means that after this commit, all core Listening Room operations should work, for both DJs and listeners. Optimized LR model updating so we don't reload unless stuff has really changed. Also added tons of debug spam and a little debug UI.

andriijas · 2013-04-29T06:08:08Z

Would love to get this into master soon :) thanks!

andriijas · 2013-08-12T09:15:27Z

4 months since my comment. Why isnt this getting merged? :)

teo · 2013-08-12T09:27:13Z

On Mon, Aug 12, 2013 at 11:15 AM, Andreas Cederström
[email protected] wrote:

4 months since my comment. Why isnt this getting merged? :)

—
Reply to this email directly or view it on GitHub.

Because it's not ready for merging yet, it needs some finishing and
fixing and there are only 24 hours in a day :(

It is on my to-do list, it will take a while more, and it will be
merged as soon as possible.

andriijas · 2013-08-12T10:01:46Z

meant to stress you man. just wanted to know the current status. appreciate your efforts :)

Builds ok, but functionality is broken. Conflicts: resources.qrc src/CMakeLists.txt src/libtomahawk/ActionCollection.cpp src/libtomahawk/CMakeLists.txt src/libtomahawk/LatchManager.cpp src/libtomahawk/Source.cpp src/libtomahawk/Source.h src/libtomahawk/Typedefs.h src/libtomahawk/ViewManager.cpp src/libtomahawk/ViewManager.h src/libtomahawk/database/DatabaseCommand.cpp src/libtomahawk/playlist/PlayableItem.cpp src/tomahawk/TomahawkApp.cpp src/tomahawk/TomahawkWindow.cpp src/tomahawk/sourcetree/SourceDelegate.cpp src/tomahawk/sourcetree/SourceTreeView.cpp src/tomahawk/sourcetree/SourcesModel.cpp src/tomahawk/sourcetree/SourcesModel.h src/tomahawk/sourcetree/items/CategoryItems.cpp src/tomahawk/sourcetree/items/CategoryItems.h

Also disabled PartyModel and related widgets.

andriijas · 2013-12-11T07:58:17Z

All i want for christmas is listening rooms :)

lfranchi · 2014-09-13T04:04:02Z

@teo out of curiosity, what's the current state here? :)

teo · 2014-09-13T08:55:47Z

Unfinished, it still requires a bit of work.

lfranchi · 2014-12-22T23:22:39Z

@teo I know this has been a while, but do you still remember what work is remaining? I figure if you write it down, there's a higher chance of it being picked up on. Maybe I'll even take a look...

Sytten · 2015-12-25T02:46:03Z

Any news? its a feature that lacks in tomahawk compared to other music player...

lfranchi reviewed Nov 22, 2012
View reviewed changes

teo added 7 commits November 24, 2012 16:22

Make the Listening Room's history view act like a history view.

daa22dd

More LR DJ semantics.

6e0967e

Fix reorder warnings.

e568c3c

Fixed ListeningRoomModel logic. DJ should now send correct LR data.

aac18f5

Implement LR current row propagation.

46fa016

This means that after this commit, all core Listening Room operations should work, for both DJs and listeners. Optimized LR model updating so we don't reload unless stuff has really changed. Also added tons of debug spam and a little debug UI.

Removed debug spam and debug UI.

91d55de

Do not show expanded drop area for listening rooms.

84a3916

teo added 12 commits October 23, 2013 14:11

Remove Listening Room renaming. TODO differently.

30f0b26

Listening Rooms are now Parties

e947231

Fix icon name

3f1208f

Fix Party postCommitHook

2fbbd37

Only allow one party per Source

4cfdb52

Removed ListeningRoomEntry in favor of reusing Playlist.

1d7eef3

Also disabled PartyModel and related widgets.

Unbreak playlist deletion.

afd79f8

Don't show a party's playlist in the playlists category.

3fee44a

Bring back the old listening rooms UI

7c09f88

Added sidebar and command widget to party layout.

e654f6b

Unbreak Party Disband slot.

0ab28a2

Debug spam++

789aa87

xhochy changed the title ~~Listening Rooms~~ [WIP] Listening Rooms May 6, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Listening Rooms #128

[WIP] Listening Rooms #128

teo commented Nov 12, 2012

Ramblurr commented Nov 14, 2012

teo commented Nov 20, 2012

lfranchi commented Nov 20, 2012

lfranchi Nov 22, 2012

lfranchi commented Nov 22, 2012

lfranchi Nov 22, 2012

andriijas commented Apr 29, 2013

andriijas commented Aug 12, 2013

teo commented Aug 12, 2013

andriijas commented Aug 12, 2013

andriijas commented Dec 11, 2013

lfranchi commented Sep 13, 2014

teo commented Sep 13, 2014

lfranchi commented Dec 22, 2014

Sytten commented Dec 25, 2015



		void
		ListeningRoomModel::endRoomChanges()

[WIP] Listening Rooms #128

Are you sure you want to change the base?

[WIP] Listening Rooms #128

Conversation

teo commented Nov 12, 2012

Ramblurr commented Nov 14, 2012

teo commented Nov 20, 2012

lfranchi commented Nov 20, 2012

lfranchi Nov 22, 2012

Choose a reason for hiding this comment

lfranchi commented Nov 22, 2012

lfranchi Nov 22, 2012

Choose a reason for hiding this comment

andriijas commented Apr 29, 2013

andriijas commented Aug 12, 2013

teo commented Aug 12, 2013

andriijas commented Aug 12, 2013

andriijas commented Dec 11, 2013

lfranchi commented Sep 13, 2014

teo commented Sep 13, 2014

lfranchi commented Dec 22, 2014

Sytten commented Dec 25, 2015