Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Hello!
Pull Request overview
model.generate
Details
The
_update_model_kwargs_for_generation
method inGenerationMixin
would endlessly grow theattention_mask
to match thepast_key_values + 1
, which is normally very reasonable. However, withattention_sinks
we eventually cap thepast_key_values
, so it ended up crashing.This change very simply prevents the endless growth of the
attention_mask
so it always matchespast_key_values + 1
.Usage