Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 #49

Merged
merged 10 commits into from
Sep 10, 2021
Merged

Version 3.0.0 #49

merged 10 commits into from
Sep 10, 2021

Conversation

tom-james-watson
Copy link
Owner

@tom-james-watson tom-james-watson commented Aug 14, 2021

Includes the following major changes:

  • Bundle NotoColorEmoji into the app (Use packaged emoji font instead of system font #40). This means that you always get the latest version of NotoColorEmoji in the app and avoids situations where you don't see new unsupported emojis in the snap version of the app.
  • Switch to use openmoji data as the data source for the emojis (Switch emoji data source #47). This means we add support for a whole bunch of emojis that were missing. It also means that the aliases of some emojis will have changed, and potentially which category some emojis are in too.
  • Added a skintone selector (Skin tones #39). Adds a dropdown to the header that changes all compatible emojis in real time.

Testing

I will leave this open for a few days to give users a chance to test it out and provide feedback.

Either check out the v3 branch and run locally, or install the edge channel of the app with snap install emote --edge.

Preview

skintone.mp4

@tom-james-watson tom-james-watson added the help wanted Extra attention is needed label Aug 14, 2021
@tom-james-watson
Copy link
Owner Author

tom-james-watson commented Aug 14, 2021

There's currently an unsupported emoji in the smiley category that breaks the layout. Removing and will push a fix.

Done.

@waldyrious
Copy link
Contributor

or install the edge channel of the app with snap install emote --edge.

Heads-up: for those who already have the snap installed, the command needs to be snap refresh emote --edge instead.

@waldyrious
Copy link
Contributor

waldyrious commented Aug 14, 2021

I can confirm this works for me, and I can now input 🥲 as asked for in #46! I'll continue testing in the next few days and will report any issues I come across.

Edit: funny thing, the emoji above appears when typing into the text box, but not when viewing the rendered comment here on GitHub. Though of course, that's not Emote's fault.

emote/emojis.py Outdated Show resolved Hide resolved
@waldyrious
Copy link
Contributor

waldyrious commented Aug 27, 2021

I've been testing this for the past few days, and overall the experience has been great, but I just noticed a couple issues with the 🧹 and 🧩 characters:

Screenshot from 2021-08-27 15-30-57_

The same problem appears to be there for the skin tone marker. And speaking of which, note that there are two instances of 👨 (:man:) in there; those were due to trying out two different skin tones, but that isn't reflected in the list. Either the skin tone should be preserved in the history, or the two entries should be merged (if the idea is for them to use the currently selected skin tone).

@tom-james-watson
Copy link
Owner Author

Sorry for the delay - I've been away on holiday 🏖️

Good catch on the duplicate recent emojis. I've just fixed that.

Not sure what is up with your missing emojis though. You're running the snap build, right? What OS and version are you running?

@tom-james-watson
Copy link
Owner Author

On the couple of other real-world installations (Ubuntu 20.04 and Ubuntu 21.04) those emojis all render fine.

@waldyrious
Copy link
Contributor

waldyrious commented Sep 3, 2021

You're running the snap build, right? What OS and version are you running?

Yes. I'm running the snap from the edge channel, and my system is Ubuntu 20.04. For the record, I don't recall seeing this issue before, and I am now seeing non-emoji presentation for emoji characters in other places as well, so I'd say the bug is on my system rather than on Emote.

@tom-james-watson
Copy link
Owner Author

I'll try and test out on a few different VMs when I get the chance, or see if anyone else chimes in. If not I'll just release this soon and see what feedback we get 🤷‍♂️.

@tom-james-watson
Copy link
Owner Author

I've pushed 3.0.2 to edge if you want to get the fix for the duplicate recent emojis. They won't clear from your recent list, it just prevents it from happening.

@tom-james-watson tom-james-watson merged commit cfa8021 into master Sep 10, 2021
@catthanh
Copy link

Hi, I notice that the skin options only change the default emoji not the gender emoji. Please add gender skin support 🙆🏽🙆‍♂️🙆‍♀️

@tom-james-watson
Copy link
Owner Author

Ongoing discussion about this in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants