feat: tolgee SDK v6 #793
Merged
feat: tolgee SDK v6 #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tolgee-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JanCizmar
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Good job! 👍
- There is many Grammarly issues, can you please always run it trough Grammarly befor you submit the PR?
- It looks like you don't have spellcheck in the IDE, do you?
- Wouldn't be beneficial to create special Next package now, when we release V6 in one bigger update removing the need to the boilerplate code users need to add when working with next?
stepan662
force-pushed
the
stepangranat/sdk-v6
branch
from
daaec91 to
7164785
Compare
JanCizmar
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Since I would like to post this on the Next.js reddit group, I would remove the emojis from the post. Usually on reddit people are pretty sensitive about emojis.
Lately I've posted this link to Kotlin group and it has 100% upvote rate, which I believe is beacuse on Reddit people like "raw" tests which don't look much like self promotion.
https://docs.tolgee.io/blog/2024-12-28-compose-multiplatform-import-export
|
Ok, done @JanCizmar |
JanCizmar
approved these changes
Jan 8, 2025
stepan662
added a commit
to tolgee/tolgee-js
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.