Add manual crop #33
Merged
Add manual crop #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| err = engine.Crop(coodinates.CropWidth, coodinates.CropHeight, coodinates.WidthOffset, coodinates.HeightOffset) | ||
| if err != nil { | ||
| return &ResizeResult{err: logger.ErrorDebug(err)} | ||
| } |
There was a problem hiding this comment.
[IMO] 条件複雑になっちゃうので、全部クロップを最初に倒したほうが良さそうですけどどうでしょう？
|
@TakatoshiMaeda パラメータを分割しました。 |
| @@ -90,8 +102,60 @@ func ParseGeometry(geo string) (*Geometry, error) { | |||
| pos = GEO_AUTO_CROP | |||
| if cond[1] == "true" { | |||
| needsAutoCrop = true | |||
| } else if cond[1] == "manual" { | |||
There was a problem hiding this comment.
manualにするのであれば、trueもautoにして対にしたいですね。
mc=trueのような形式にしなかったのは理由ありますか？
| engine.SetSizeHint(coodinates.ResizeWidth, coodinates.ResizeHeight) | ||
| if option.NeedsManualCrop { | ||
| // open with source image size. | ||
| engine.SetSizeHint(option.SizeHintWidth, option.SizeHintHeight) |
There was a problem hiding this comment.
[IMO]
一段浅いifのblockで
if option.HasSizeHint() && !option.NeedsManualCrop {
calculator.SetImageSize(option.SizeHintWidth, option.SizeHintHeight)
coodinates = calculator.Calc(option)
engine.SetSizeHint(coodinates.ResizeWidth, coodinates.ResizeHeight)
}
こうするのが意図がわかりやすいかなと思いました
There was a problem hiding this comment.
なるほど。
修正しました。
305790f
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #11
Manual croppingを追加しました。
Auto croppingとは違いcropの順番を変えたほうが効率が良いので、先にcroppingしてからリサイズするようにしています。
フラグを持つことでAuto croppingの場合は順序を変えていません。