Add missing unwrap()s
#753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tx.send()` returns a `Result` which must be used otherwise the compiler produces warnings.
Darksonn
reviewed
Mar 4, 2024
content/tokio/tutorial/channels.md
Outdated
Comment on lines
178
to
179
| // send() returns a `Result` which cannot be ignored. | ||
| tx.send("sending from first handle").await.unwrap(); |
There was a problem hiding this comment.
Thanks! I don't think the comment is necessary for the documentation. It explains your change well, but I don't think someone who sees it with unwrap() from the beginning will be confused about it.
There was a problem hiding this comment.
Makes sense, I removed the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tx.send()returns aResultwhich must be used otherwise the compiler produces warnings.