Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode support #701

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

stanwolverine
Copy link
Contributor

@stanwolverine stanwolverine commented Apr 29, 2023

Hello everyone,

I'm excited to share this PR for adding dark theme support. Please visit the preview, I would really appreciate your feedback and suggestions.
You can also suggest some better colors for the dark theme.
I'd also like to know if there are any UI elements where the dark theme changes have not been applied or any other feedback, I'm all ears.

Thank you so much for taking the time to review my PR and provide your insights. I look forward to hearing your thoughts!

Pending actions on this PR:

  • Add Button to Toggle theme
  • check the accessibility of colors

@Darksonn
Copy link
Contributor

How do I get my browser to switch to dark mode?

@stanwolverine
Copy link
Contributor Author

@Darksonn If you "turn on" dark theme on your device, then website will also switch to dark mode

@stanwolverine
Copy link
Contributor Author

for example, on macOS you can use highlighted option in image:

Screenshot 2023-04-30 at 2 06 35 AM

@hawkw
Copy link
Member

hawkw commented Apr 30, 2023

Looks nice on my machine, at least!
image

@stanwolverine
Copy link
Contributor Author

@hawkw also checkout docs and code snippets

@Darksonn
Copy link
Contributor

Darksonn commented May 1, 2023

Sure, this sounds good to me. I would be happy to merge this. Did you have any further changes you wanted to get in before I do so?

@stanwolverine
Copy link
Contributor Author

@Darksonn let me add a button to toggle theme, then we can merge it

@stanwolverine stanwolverine marked this pull request as ready for review May 6, 2023 18:12
@stanwolverine
Copy link
Contributor Author

stanwolverine commented May 6, 2023

Hey @Darksonn, You can review and merge this PR now if everything looks good

@Darksonn
Copy link
Contributor

Darksonn commented May 7, 2023

I tried clicking the button on this page, but the area to the right of the page remains white. See the screenshot below.

Screenshot

@stanwolverine
Copy link
Contributor Author

I tried clicking the button on this page, but the area to the right of the page remains white. See the screenshot below.

Screenshot

@Darksonn fixed this

@joshka joshka mentioned this pull request Oct 18, 2024
@joshka
Copy link
Contributor

joshka commented Oct 28, 2024

Bulma 1.0 has dark mode support built-in, but is a little complex to upgrade. See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants