derive: implement #[valuable] attributes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Would love to see this getting added! |
|
Any news on this? |
davidbarsky
approved these changes
Jul 17, 2024
|
Hey, I'm not sure why this pr stalled out, but I really like the functionality and the way you've written it. I am going to try to push it forward. I added a new pr that duplicates the work you did here (and rightly attributes authorship to you). My pr also includes a macro attribute for formatting a field for including a simplified version of a field when the field's type doesn't implement |
carllerche
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step for #51.
#[valuable(rename = "...")]#[valuable(transparent)]#[valuable(skip)](This commit was created about 5 months ago. However, I didn't open the PR at the time because something was missing, but I don't remember what it is anymore, so I'll open the PR as a draft anyway.)