Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.56 #117

Closed
wants to merge 2 commits into from
Closed

Bump MSRV to 1.56 #117

wants to merge 2 commits into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Aug 10, 2023 •
edited
Loading

The latest proc-macro2 requires Rust 1.56.

https://github.com/tokio-rs/valuable/actions/runs/5817933075/job/15773398918

error: edition 2021 is unstable and only available with -Z unstable-options.

error: could not compile `proc-macro2`

(The first commit is from #116, and is needed to fix another CI failure.)

@taiki-e taiki-e requested a review from hawkw August 10, 2023 07:06
@taiki-e taiki-e mentioned this pull request Aug 10, 2023
Merged
@taiki-e taiki-e closed this Aug 19, 2023
@taiki-e taiki-e deleted the taiki-e/msrv branch August 19, 2023 00:54
@taiki-e taiki-e removed the request for review from hawkw August 19, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e