Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Looks like Clippy is once again complaining about the
match_wild_err_arm
lint, presumably as a result of the Rust 1.42release. This lint triggers on the
try_lock!
macro thattracing-subscriber
uses to avoid double panics when a mutex ispoisoned. In this case, the lint is something of a false positive here,
since we do actually have two different
Err(...)
arms; thedifferentiation between the two arms is not in the match pattern but in
a guard. See rust-lang/rust-clippy#3688 for
details on the lint.
Solution
I've refactored the code in question to use
if
/else
, avoiding thelint.
Signed-off-by: Eliza Weisman [email protected]