Conversation
jplatte
force-pushed
the
jplatte/core-no-std
branch
from
364cacb to
b6e7321
Compare
djc
approved these changes
Sep 5, 2025
Contributor
There was a problem hiding this comment.
I like it!
In other crates, we've set up #![warn(clippy::alloc_instead_of_core, clippy::std_instead_of_core)] which might provide a better development experience?
Sorry for the slow feedback -- mentioning me on GitHub might work better than Discord.
Contributor
Author
No worries, this is still plenty fast in terms of feedback on tracing PRs 🫠 |
Contributor
|
Do you have privileges in this repo? If not, I guess I can just merge it. |
… except std::sync::Mutex, which there is a polyfill for.
jplatte
force-pushed
the
jplatte/core-no-std
branch
from
b6e7321 to
f42f840
Compare
hds
added a commit
that referenced
this pull request
Nov 24, 2025
# 0.1.35 (November 24, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 24, 2025
# 0.1.35 (November 24, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 26, 2025
# 0.1.35 (November 26, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 26, 2025
# 0.1.35 (November 26, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 26, 2025
# 0.1.35 (November 26, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… and update imports accordingly.
Motivation
Makes the code less weird, and makes
stddependencies clearer by not using the prelude anymore.Solution
See individual commits.
@hds if you like this, I can convert the remaining crates that currently have
#![cfg_attr(not(feature = "std"), no_std)]to this style in follow-up PRs.