Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forward-port attributes changes #3095

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

davidbarsky
Copy link
Member

#2864 and #2880 both targeted 0.1.x instead of master.

kaffarell and others added 2 commits October 2, 2024 14:37
When using `#[tracing::instrument]` and the `async unsafe` modifiers
the generated function read `unsafe async fn`, which is wrong. Corrected
the order and added a test.

Fixes: #2576

Signed-off-by: Gabriel Goller <[email protected]>
On clippy version 1.76.0 this gives a warning, extracting the
scrutinee to a variable fixes this.

Fixes: #2876
@davidbarsky davidbarsky requested review from hawkw and a team as code owners October 2, 2024 18:38
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@davidbarsky davidbarsky enabled auto-merge (squash) October 2, 2024 18:41
@davidbarsky davidbarsky disabled auto-merge October 2, 2024 18:41
@davidbarsky davidbarsky merged commit 2d30094 into master Oct 2, 2024
56 checks passed
@davidbarsky davidbarsky deleted the david/forward-port-changes-to-master branch October 2, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants