Conversation
| error, | ||
| }; | ||
|
|
||
| #[cfg(feature = "alloc")] |
There was a problem hiding this comment.
There is no alloc features defined in this crate right now.
| #[cfg(feature = "futures-01")] | ||
| mod futures_01; | ||
|
|
||
| #[cfg(feature = "futures_preview")] |
There was a problem hiding this comment.
There doesn't appear to be defined feature for futures_preview.
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "tower-util")] |
There was a problem hiding this comment.
There's no feature defined for tower-util.
djc
force-pushed
the
v0.1.x-custom-cfg
branch
3 times, most recently
from
776980e to
eb045f5
Compare
|
@hawkw so do you want to approve this? (I technically seem to have merge privileges, not sure if you want me to use them.) |
djc
force-pushed
the
v0.1.x-custom-cfg
branch
3 times, most recently
from
6e64256 to
4956112
Compare
djc
force-pushed
the
v0.1.x-custom-cfg
branch
from
4956112 to
7fc7b16
Compare
davidbarsky
left a comment
davidbarsky
left a comment
There was a problem hiding this comment.
LGTM; would be good to have these on master as well.
|
What's the state of master these days? Feels like keeping master for 0.2.x is a little counterproductive if the pace towards actually releasing 0.2.x is low. |
I agree. IMO either we try to release 0.2.x soonish, or we reverse the roles and have 0.1.x -> master and master -> 0.2.x. |
4 participants
Motivation
Trying to clean up the proliferation of warnings seen with rustc 1.80 (and
--all-features).(Best reviewed per commit.)