subscriber: skip padding when skipping log.* fields in DefaultVisitor#2980
Merged
hds merged 6 commits intotokio-rs:masterfrom Dec 2, 2024
Merged
subscriber: skip padding when skipping log.* fields in DefaultVisitor#2980hds merged 6 commits intotokio-rs:masterfrom
log.* fields in DefaultVisitor#2980hds merged 6 commits intotokio-rs:masterfrom
Conversation
hds
reviewed
May 24, 2024
Contributor
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
What do you think about moving the check for log metadata to before the match statement?
Porges
commented
May 26, 2024
Porges
force-pushed
the
only-pad-if-writing
branch
from
03a6f54 to
b8f6828
Compare
hds
changed the title
log.* fields in DefaultVisitor
|
same here |
|
Hi @hds, it's been a while since |
25 tasks
hds
pushed a commit
that referenced
this pull request
May 27, 2025
…tor` (#2980) ## Motivation The current behaviour of `DefaultVisitor` is that it will write padding even if it is going to skip writing a value, which results in extraneous padding being added when values are skipped by the `tracing-log` integration. ## Solution With this change, `DefaultVisitor` will only insert padding if it is actually going to write a value. Closes: #2979
hds
pushed a commit
that referenced
this pull request
Jun 3, 2025
…tor` (#2980) ## Motivation The current behaviour of `DefaultVisitor` is that it will write padding even if it is going to skip writing a value, which results in extraneous padding being added when values are skipped by the `tracing-log` integration. ## Solution With this change, `DefaultVisitor` will only insert padding if it is actually going to write a value. Closes: #2979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2979.
The current behaviour of
DefaultVisitoris that it will write padding even if it is going to skip writing a value, which results in extraneous padding being added when values are skipped by thetracing-logintegration.Solution
With this change,
DefaultVisitorwill only insert padding if it is actually going to write a value.