Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare tracing-appender 0.2.3 release #2790

Merged
merged 14 commits into from
Nov 13, 2023

Conversation

davidbarsky
Copy link
Member

Building atop of #2789, but we'll land that one first.

@davidbarsky davidbarsky requested review from a team and hawkw as code owners November 6, 2023 21:41
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the tracing-subscriber release is out!


### Changed

- **non_blocking**: name spawned threads ([#2219])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels like "added" to me, but your mileage may vary 🤷‍♀️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's added. I'll make "changed" stuff for breaking changes and otherwise internal, but noteworthy, fixes.

@hawkw
Copy link
Member

hawkw commented Nov 6, 2023

looks like we need to fix some min-versions dependency breakage as well...

@davidbarsky
Copy link
Member Author

looks like we need to fix some min-versions dependency breakage as well...

@hawkw Trying out a fix in #2792.

@hawkw
Copy link
Member

hawkw commented Nov 7, 2023

now that we've merged #2794, we'll need to update the changelog to reflect additional changes that were backported in that PR.

@davidbarsky davidbarsky force-pushed the david/prepare-tracing-appender-0.2.3 branch from 3486105 to d45c853 Compare November 12, 2023 22:04
@davidbarsky davidbarsky force-pushed the david/prepare-tracing-appender-0.2.3 branch from d45c853 to c486633 Compare November 13, 2023 14:24
@hawkw
Copy link
Member

hawkw commented Nov 13, 2023

I just shipped tracing-subscriber v0.3.18, so I think we need to bump the tracing-subscriber version here as well, and then we can ship this!

@davidbarsky
Copy link
Member Author

on it!

tracing-appender/CHANGELOG.md Outdated Show resolved Hide resolved
@hawkw hawkw enabled auto-merge (squash) November 13, 2023 18:59
@hawkw hawkw merged commit c6bedbe into v0.1.x Nov 13, 2023
52 checks passed
@hawkw hawkw deleted the david/prepare-tracing-appender-0.2.3 branch November 13, 2023 19:06
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request Feb 14, 2024
# 0.2.3 (November 13, 2023)

This release contains several new features. It also increases the
minimum supported Rust version (MSRV) to Rust 1.63.0.

## Added

- **rolling**: add option to automatically delete old log files (tokio-rs#2323)
- **non_blocking**: allow worker thread name to be configured (tokio-rs#2365)
- **rolling**: add a builder for constructing `RollingFileAppender`s
  (tokio-rs#2227)
- **rolling**: add `Builder::filename_suffix` parameter (tokio-rs#2225)
- **non_blocking**: remove `Sync` bound from writer for `NonBlocking`
  (tokio-rs#2607)
- **non_blocking**: name spawned threads (tokio-rs#2219)

## Fixed

- Fixed several documentation typos and issues (tokio-rs#2689, tokio-rs#2375)

## Changed

- Increased minimum supported Rust version (MSRV) to 1.63.0+ (tokio-rs#2793)
- Updated minimum `tracing-subscriber` version to
  [0.3.18][subscriber-v0.3.18] (tokio-rs#2790)

[subscriber-v0.3.18]:
    https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.18
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.2.3 (November 13, 2023)

This release contains several new features. It also increases the
minimum supported Rust version (MSRV) to Rust 1.63.0.

## Added

- **rolling**: add option to automatically delete old log files (tokio-rs#2323)
- **non_blocking**: allow worker thread name to be configured (tokio-rs#2365)
- **rolling**: add a builder for constructing `RollingFileAppender`s
  (tokio-rs#2227)
- **rolling**: add `Builder::filename_suffix` parameter (tokio-rs#2225)
- **non_blocking**: remove `Sync` bound from writer for `NonBlocking`
  (tokio-rs#2607)
- **non_blocking**: name spawned threads (tokio-rs#2219)

## Fixed

- Fixed several documentation typos and issues (tokio-rs#2689, tokio-rs#2375)

## Changed

- Increased minimum supported Rust version (MSRV) to 1.63.0+ (tokio-rs#2793)
- Updated minimum `tracing-subscriber` version to
  [0.3.18][subscriber-v0.3.18] (tokio-rs#2790)

[subscriber-v0.3.18]:
    https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants