Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare tracing-log 0.2.0 #2772

Merged
merged 5 commits into from
Oct 24, 2023
Merged

chore: prepare tracing-log 0.2.0 #2772

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dec7cf7
chore: prepare tracing-log 0.2.0
davidbarsky Oct 23, 2023
ab5ef79
update changelog to include `trace_logger` removal.
davidbarsky Oct 24, 2023
d018fad
bump tracing-subscriber dependency on tracing-log
davidbarsky Oct 24, 2023
02ac221
Update CHANGELOG.md
davidbarsky Oct 24, 2023
0ffa67b
Update CHANGELOG.md
hawkw Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tracing-log/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,24 @@
# 0.2.0 (October 23rd, 2023)
davidbarsky marked this conversation as resolved.
Show resolved Hide resolved

This release contains two breaking changes: the removal of the `env_logger`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we maybe mention that they were already deprecated in 0.1.x?

and `trace_logger` features. Below are the suggested migration paths:

- `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`]
or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`]
filters instead.
- `trace_logger`: users should use the `tracing` crate's "log" feature flag instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link to the tracing crate docs discussing this feature?


### Breaking Changes

- Remove `env_logger` feature ([#2771])
- Remove `trace_logger` feature ([#2771])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we maybe mention somewhere in here that env_logger was removed as part of mitigation for a RustSec advisory?


[#2771]: https://github.com/tokio-rs/tracing/pull/2771
[`tracing_subscriber::fmt::Subscriber`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Subscriber.html
[`tracing_subscriber::fmt::Layer`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Layer.html
[`Targets`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/targets/struct.Targets.html
[`EnvFilter`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html

# 0.1.4 (October 23rd, 2023)

### Changes
Expand Down
2 changes: 1 addition & 1 deletion tracing-log/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tracing-log"
version = "0.1.4"
version = "0.2.0"
authors = ["Tokio Contributors <[email protected]>"]
edition = "2018"
repository = "https://github.com/tokio-rs/tracing"
Expand Down
4 changes: 2 additions & 2 deletions tracing-subscriber/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ smallvec = { optional = true, version = "1.9.0" }
once_cell = { optional = true, version = "1.13.0" }

# fmt
tracing-log = { path = "../tracing-log", version = "0.1.3", optional = true, default-features = false, features = ["log-tracer", "std"] }
tracing-log = { path = "../tracing-log", version = "0.2.0", optional = true, default-features = false, features = ["log-tracer", "std"] }
nu-ansi-term = { version = "0.46.0", optional = true }
time = { version = "0.3.2", features = ["formatting"], optional = true }

Expand All @@ -73,7 +73,7 @@ valuable-serde = { version = "0.1.0", optional = true, default-features = false
tracing = { path = "../tracing", version = "0.1.35" }
tracing-mock = { path = "../tracing-mock", features = ["tracing-subscriber"] }
log = "0.4.17"
tracing-log = { path = "../tracing-log", version = "0.1.3" }
tracing-log = { path = "../tracing-log", version = "0.2.0" }
criterion = { version = "0.3.6", default-features = false }
regex = { version = "1", default-features = false, features = ["std"] }
tracing-futures = { path = "../tracing-futures", version = "0.2.0", default-features = false, features = ["std-future", "std"] }
Expand Down
Loading