attributes: fix incorrect default level in docs #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects contradictory information in the documentation --- in one section, we state that the default level is `INFO` (which is correct), but in the examples, we say it's `TRACE`, which is wrong. This commit fixes that. Fixes #2117 Signed-off-by: Eliza Weisman <[email protected]>
davidbarsky
approved these changes
May 11, 2022
hawkw
added a commit
that referenced
this pull request
Jul 1, 2022
# 0.1.22 (July 1, 2022) This release fixes an issue where using the `err` or `ret` arguments to `#[instrument]` along with an overridden target, such as ```rust #[instrument(target = "...", err, ret)] ``` would not propagate the overridden target to the events generated for errors/return values. ### Fixed - Error and return value events generated by `#[instrument(err)]` or `#[instrument(ret)]` not inheriting an overridden target (#2184) - Incorrect default level in documentation (#2119) Thanks to new contributor @tbraun96 for contributing to this release!
hawkw
added a commit
that referenced
this pull request
Jul 1, 2022
# 0.1.22 (July 1, 2022) This release fixes an issue where using the `err` or `ret` arguments to `#[instrument]` along with an overridden target, such as ```rust #[instrument(target = "...", err, ret)] ``` would not propagate the overridden target to the events generated for errors/return values. ### Fixed - Error and return value events generated by `#[instrument(err)]` or `#[instrument(ret)]` not inheriting an overridden target (#2184) - Incorrect default level in documentation (#2119) Thanks to new contributor @tbraun96 for contributing to this release!
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.22 (July 1, 2022) This release fixes an issue where using the `err` or `ret` arguments to `#[instrument]` along with an overridden target, such as ```rust #[instrument(target = "...", err, ret)] ``` would not propagate the overridden target to the events generated for errors/return values. ### Fixed - Error and return value events generated by `#[instrument(err)]` or `#[instrument(ret)]` not inheriting an overridden target (tokio-rs#2184) - Incorrect default level in documentation (tokio-rs#2119) Thanks to new contributor @tbraun96 for contributing to this release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects contradictory information in the documentation --- in one
section, we state that the default level is
INFO(which is correct),but in the examples, we say it's
TRACE, which is wrong. This commitfixes that.
Fixes #2117
Signed-off-by: Eliza Weisman [email protected]