subscriber: add missing Filter::on_record for to EnvFilter
#2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Currently, there is a potential namespace resolution issue when calling `EnvFilter` methods that have the same name in the `Filter` and `Subscribe` traits (such as `enabled` and `max_level_hint`). When both `Filter` and `Subscribe` are in scope, the method resolution is ambiguous. See #1983 (comment) ## Solution This commit solves the problem by making the inherent method versions of these methods public. When the traits are in scope, name resolution will always select the inherent method prefer`entially, preventing the name clash.
Signed-off-by: Eliza Weisman <[email protected]>
Depends on #2057 ## Motivation Currently, `EnvFilter`'s `Subscribe` implementation provides a `Subscribe::on_record` method, but its `Filter` implementation is missing the corresponding `Filter::on_record` implementation. This means that when using `EnvFilter` as a per-subscriber filter, recording span fields after the spans were created will not update the filter state. ## Solution This commit factors out the `on_record` implementation for `Subscribe` into an inherent method, and adds a new `Filter::on_record` method that calls it as well.
davidbarsky
approved these changes
Apr 8, 2022
hawkw
added a commit
that referenced
this pull request
Apr 8, 2022
Depends on #2057 ## Motivation Currently, `EnvFilter`'s `Layer` implementation provides a `Layer::on_record` method, but its `Filter` implementation is missing the corresponding `Filter::on_record` implementation. This means that when using `EnvFilter` as a per-layer filter, recording span fields after the spans were created will not update the filter state. ## Solution This commit factors out the `on_record` implementation for `Layer` into an inherent method, and adds a new `Filter::on_record` method that calls it as well. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Apr 9, 2022
Depends on #2057 ## Motivation Currently, `EnvFilter`'s `Layer` implementation provides a `Layer::on_record` method, but its `Filter` implementation is missing the corresponding `Filter::on_record` implementation. This means that when using `EnvFilter` as a per-layer filter, recording span fields after the spans were created will not update the filter state. ## Solution This commit factors out the `on_record` implementation for `Layer` into an inherent method, and adds a new `Filter::on_record` method that calls it as well. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Apr 9, 2022
# 0.3.11 (Apr 9, 2022) This is a bugfix release for the `Filter` implementation for `EnvFilter` added in [v0.3.10]. ### Fixed - **env-filter**: Added missing `Filter::on_record` callback to `EnvFilter`'s `Filter` impl ([#2058]) - **env-filter**: Fixed method resolution issues when calling `EnvFilter` methods with both the `Filter` and `Layer` traits in scope ([#2057]) - **env-filter**: Fixed `EnvFilter::builder().parse()` and other parsing methods returning an error when parsing an empty string ([#2052]) Thanks to new contributor @Ma124 for contributing to this release! [v0.3.10]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.10 [#2058]: #2058 [#2057]: #2057 [#2052]: #2052
hawkw
added a commit
that referenced
this pull request
Apr 9, 2022
# 0.3.11 (Apr 9, 2022) This is a bugfix release for the `Filter` implementation for `EnvFilter` added in [v0.3.10]. ### Fixed - **env-filter**: Added missing `Filter::on_record` callback to `EnvFilter`'s `Filter` impl ([#2058]) - **env-filter**: Fixed method resolution issues when calling `EnvFilter` methods with both the `Filter` and `Layer` traits in scope ([#2057]) - **env-filter**: Fixed `EnvFilter::builder().parse()` and other parsing methods returning an error when parsing an empty string ([#2052]) Thanks to new contributor @Ma124 for contributing to this release! [v0.3.10]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.10 [#2058]: #2058 [#2057]: #2057 [#2052]: #2052
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
…-rs#2058) Depends on tokio-rs#2057 ## Motivation Currently, `EnvFilter`'s `Layer` implementation provides a `Layer::on_record` method, but its `Filter` implementation is missing the corresponding `Filter::on_record` implementation. This means that when using `EnvFilter` as a per-layer filter, recording span fields after the spans were created will not update the filter state. ## Solution This commit factors out the `on_record` implementation for `Layer` into an inherent method, and adds a new `Filter::on_record` method that calls it as well. Signed-off-by: Eliza Weisman <[email protected]>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.3.11 (Apr 9, 2022) This is a bugfix release for the `Filter` implementation for `EnvFilter` added in [v0.3.10]. ### Fixed - **env-filter**: Added missing `Filter::on_record` callback to `EnvFilter`'s `Filter` impl ([tokio-rs#2058]) - **env-filter**: Fixed method resolution issues when calling `EnvFilter` methods with both the `Filter` and `Layer` traits in scope ([tokio-rs#2057]) - **env-filter**: Fixed `EnvFilter::builder().parse()` and other parsing methods returning an error when parsing an empty string ([tokio-rs#2052]) Thanks to new contributor @Ma124 for contributing to this release! [v0.3.10]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.10 [tokio-rs#2058]: tokio-rs#2058 [tokio-rs#2057]: tokio-rs#2057 [tokio-rs#2052]: tokio-rs#2052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2057
Motivation
Currently,
EnvFilter'sSubscribeimplementation provides aSubscribe::on_recordmethod, but itsFilterimplementation ismissing the corresponding
Filter::on_recordimplementation. This meansthat when using
EnvFilteras a per-subscriber filter, recording spanfields after the spans were created will not update the filter state.
Solution
This commit factors out the
on_recordimplementation forSubscribeinto an inherent method, and adds a new
Filter::on_recordmethod thatcalls it as well.