Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): attempt to automate github releases #1795

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Dec 21, 2021

Hopefully this should automatically publish a GitHub release with
each individual crate's changelog when an appropriate tag is pushed,
provided I haven't made a YAML mistake.

@hawkw hawkw requested review from davidbarsky and a team as code owners December 21, 2021 22:57
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's cool.

Signed-off-by: Eliza Weisman <[email protected]>
@hawkw
Copy link
Member Author

hawkw commented Dec 22, 2021

okay, I think the glob syntax is actually correct now!

@hawkw hawkw merged commit 9274db4 into master Dec 22, 2021
@hawkw hawkw deleted the eliza/autorelease branch December 22, 2021 17:17
hawkw added a commit that referenced this pull request Dec 23, 2021
Hopefully this should automatically publish a GitHub release with
each individual crate's changelog when an appropriate tag is pushed,
provided I haven't made a YAML mistake.

Signed-off-by: Eliza Weisman <[email protected]>
hawkw added a commit that referenced this pull request Dec 23, 2021
Hopefully this should automatically publish a GitHub release with
each individual crate's changelog when an appropriate tag is pushed,
provided I haven't made a YAML mistake.

Signed-off-by: Eliza Weisman <[email protected]>
- uses: actions/checkout@v2
- uses: taiki-e/[email protected]
with:
prefix: tracing[\-a-z]*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash's =~ doesn't seem to handle escaped - well, so you need to write the following: tracing[a-z-]*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the handling of hyphens within a prefix is complicated (taiki-e/create-gh-release-action#10), so perhaps the following is more robust: tracing(-[a-z]+)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants