-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): attempt to automate github releases #1795
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, that's cool.
Signed-off-by: Eliza Weisman <[email protected]>
okay, I think the glob syntax is actually correct now! |
Hopefully this should automatically publish a GitHub release with each individual crate's changelog when an appropriate tag is pushed, provided I haven't made a YAML mistake. Signed-off-by: Eliza Weisman <[email protected]>
Hopefully this should automatically publish a GitHub release with each individual crate's changelog when an appropriate tag is pushed, provided I haven't made a YAML mistake. Signed-off-by: Eliza Weisman <[email protected]>
- uses: actions/checkout@v2 | ||
- uses: taiki-e/[email protected] | ||
with: | ||
prefix: tracing[\-a-z]* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash's =~
doesn't seem to handle escaped -
well, so you need to write the following: tracing[a-z-]*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the handling of hyphens within a prefix is complicated (taiki-e/create-gh-release-action#10), so perhaps the following is more robust: tracing(-[a-z]+)?
## Motivation It is currently failing: https://github.com/tokio-rs/tracing/runs/4622678819?check_suite_focus=true See also: #1795 (comment)
## Motivation It is currently failing: https://github.com/tokio-rs/tracing/runs/4622678819?check_suite_focus=true See also: #1795 (comment)
Hopefully this should automatically publish a GitHub release with
each individual crate's changelog when an appropriate tag is pushed,
provided I haven't made a YAML mistake.