Proposal: add a poll_read_exact method to AsyncRead#7211
Closed
a1phyr wants to merge 4 commits intotokio-rs:masterfrom
Closed
Proposal: add a poll_read_exact method to AsyncRead#7211a1phyr wants to merge 4 commits intotokio-rs:masterfrom
poll_read_exact method to AsyncRead#7211a1phyr wants to merge 4 commits intotokio-rs:masterfrom
Conversation
Member
|
I don't think we want to add this method. Why do you suggest it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to
std::io::Read::read_exact, this enables optimizing this common use case for some types.If you wish not having such method stable directly, I can make it available on
tokio_unstableonly.