io: document the default capacity of the ReaderStream#7147
Merged
ADD-SP merged 4 commits intotokio-rs:masterfrom Dec 12, 2025
Merged
io: document the default capacity of the ReaderStream#7147ADD-SP merged 4 commits intotokio-rs:masterfrom
ReaderStream#7147ADD-SP merged 4 commits intotokio-rs:masterfrom
Conversation
maminrayej
added
T-docs
Member
|
Thanks for the PR. I believe changing |
Contributor
Author
Oh yeah, will do :) |
Member
|
Hi @Owez , are you still going to work on this improvement? |
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
ADD-SP
changed the title
ReaderStream capacityReaderStream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I had to read the source to figure out the default
ReaderStreamcapacitySolution
Add a little docstring line to the typical
::new()forReaderStreamto document.DEFAULT_CAPACITYis private, we could alternatively publicise it and link in the docstring to it?