Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: empty reads on File should not start a background read #7139

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Feb 5, 2025

Fixes: #7133

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-fs Module: tokio/fs labels Feb 5, 2025
@goffrie
Copy link
Contributor

goffrie commented Feb 5, 2025

should the title say "should not start a background read"?
Thanks for the fix!

@Darksonn Darksonn changed the title fs: empty reads on File should start a background read fs: empty reads on File should not start a background read Feb 5, 2025
@maminrayej maminrayej merged commit 4b3da20 into master Feb 5, 2025
82 checks passed
@maminrayej maminrayej deleted the alice/file-empty-read branch February 5, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-fs Module: tokio/fs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poll_read on a tokio::fs::File with an empty buffer returns EOF on the *next* poll
3 participants