sync: Added WeakSender to sync::broadcast::channel
#7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Jan 27, 2025
* Changed memory orderings of `num_weak_tx`: Increments happen with relaxed, decrements happen with acqrel and checks for zero happen with acquire. * Add asserts for `sync::broadcast::WeakSender` to `tests/async_send_sync.rs`
Darksonn
reviewed
Jan 28, 2025
…ade` and improved markdown docs.
|
Just want to say as the original requester of this feature THANK YOU! Frankly awesome to see how quickly this feature request was supported, y'all rock! |
I'm always looking for some issues I can work on after work to help out. Great to help you with this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closing issue #7003. Add a type
WeakSenderto thesync::broadcast::channelsimilar tosync::maps::channel.Solution
The new
WeakSendertype just stores anArc<Shared<T>>just like the normalSenderbut activeWeakSenderswill not prevent the channel from being closed if allSenders are dropped.Closes #7003.