macros: fix the clippy::needless_return lint triggered by #[tokio::test]
and #[tokio::main]
#6880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I started seeing
clippy::needless_return
lints in a CI job that runs thenightly
cargo clippy
against my code (CI link):That test doesn't do anything fancy:
I think clippy started covering more cases of "needless return" where the function has a
return
for an expression that returns a unit type.Solution
Added an
allow
for the lint to the generated code.Questions
I see there are no CI jobs that exercise the
clippy
onnightly
. Would it be fine to add one to catch regressions from nightly early? The job doesn't need to be required to pass. It can becontinue-on-error: true
and shouldn't block PRs from merging (like I do in my repo).