Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: add #[must_use] to Notified #6828

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

xoac
Copy link
Contributor

@xoac xoac commented Sep 5, 2024

Motivation

To prevent situation as in these "bug" report: #6827

Solution

Add #[must_use] to print warning while compiling or checking

@github-actions github-actions bot added the R-loom-sync Run loom sync tests on this PR label Sep 5, 2024
tokio/CHANGELOG.md Outdated Show resolved Hide resolved
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Sep 5, 2024
@xoac xoac force-pushed the chore/add-must_use-for-notfied branch from 2fbcc61 to dc5abb5 Compare September 5, 2024 13:05
@xoac xoac requested a review from Darksonn September 5, 2024 13:05
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 5dcc848 into tokio-rs:master Sep 6, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom-sync Run loom sync tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants