Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
is_closed
,is_empty
andlen
tompsc::Receiver
andmpsc::UnboundedReceiver
#6348Add
is_closed
,is_empty
andlen
tompsc::Receiver
andmpsc::UnboundedReceiver
#6348Changes from 12 commits
48587f8
be9bbeb
ccecf35
c1c870b
e655f9e
2d964a2
816aea7
8a3851a
ab5278b
8d505dd
1e50d9f
d5b1b1f
fbd1794
6537a80
ba1ccb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
is_closed
method takes&self
. Please either change this to&*tail
or changeis_closed
to&mut self
depending on which one is correct.Same in
is_empty
. In fact, it seems like you could factor out theis_empty
logic into a separate function inlist.rs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the feedback! The code is much better now