Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename docsrs to avoid conflicts (relates #6165) #6172

Closed
wants to merge 2 commits into from

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Nov 28, 2023

Since docsrs is such a popular cfg item in the ecosystem it might be worthwhile to try and avoid accidental activation like with #6165

@udoprog udoprog added T-docs Topic: documentation A-tokio Area: The main tokio crate labels Nov 28, 2023
@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR R-loom-sync Run loom sync tests on this PR labels Nov 28, 2023
@Darksonn
Copy link
Contributor

I actually think that it's preferable to keep docsrs. That way, downstream crates can access Windows items in Tokio when generating docs on Linux.

Of course, this means that we should make sure that Tokio compiles under docsrs without docs.

@Darksonn Darksonn closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR R-loom-sync Run loom sync tests on this PR T-docs Topic: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants