ci: drop MIPS targets from cross-check #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Tokio runs cross-compilation checks for the `mips-unknown-linux-gnu` and `mipsel-unknown-linux-musl` target triples. However, Rust has recently demoted these targets from Tier 2 support to Tier 3 (see rust-lang/compiler-team#648). Therefore, MIPS toolchains may not always be available, even in stable releases. This is currently [breaking our CI builds][1], as Rust 1.72.0 does not contain a standard library for `mips-unknown-linux-gnu`. This branch removes these builds from the cross-compilation check's build matrix. Tokio may still build successfully for MIPS targets, but we can't easily guarantee support when the stable Rust release train may or may not be able to build for MIPS targets. [1]: https://github.com/tokio-rs/tokio/actions/runs/5970263562/job/16197657405?pr=5947#step:3:80
Darksonn
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Tokio runs cross-compilation checks for the
mips-unknown-linux-gnuandmipsel-unknown-linux-musltarget triples. However, Rust has recently demoted these targets from Tier 2 support to Tier 3 (see rust-lang/compiler-team#648). Therefore, MIPS toolchains may not always be available, even in stable releases. This is currently breaking our CI builds, as Rust 1.72.0 does not contain a standard library formips-unknown-linux-gnu.This branch removes these builds from the cross-compilation check's build matrix. Tokio may still build successfully for MIPS targets, but we can't easily guarantee support when the stable Rust release train may or may not be able to build for MIPS targets.