Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spawn blocking methods to joinmap #5797

Merged
merged 7 commits into from
Jun 24, 2023
Merged

Add spawn blocking methods to joinmap #5797

merged 7 commits into from
Jun 24, 2023

Conversation

tthebst
Copy link
Contributor

@tthebst tthebst commented Jun 14, 2023

Motivation

In the 1.28 release spawn_blocking and spawn_blocking_on were added to JoinSet. This MR adds both function to the tokio util JoinMap

@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-task Module: tokio/task labels Jun 14, 2023
@Darksonn
Copy link
Contributor

Thanks for the PR. You will need to bump the dependency on Tokio.

hawkw
hawkw approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me overall! one minor docs nit

tokio-util/src/task/join_map.rs Show resolved Hide resolved
tokio-util/src/task/join_map.rs Show resolved Hide resolved
hawkw
hawkw reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i expanded the docs a little, let me know what you think?

tokio-util/src/task/join_map.rs Outdated Show resolved Hide resolved
tokio-util/src/task/join_map.rs Outdated Show resolved Hide resolved
@tthebst
Copy link
Contributor Author

tthebst commented Jun 19, 2023

So is this fine to merge?

@Darksonn Darksonn merged commit b8af5aa into tokio-rs:master Jun 24, 2023
@cconstantine cconstantine mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tthebst @Darksonn @hawkw