Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: move task::Id into its own file #5327

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Conversation

carllerche
Copy link
Member

This is a minor internal cleanup.

This is a minor internal cleanup.
@carllerche carllerche added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Dec 30, 2022
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Dec 30, 2022
@carllerche carllerche removed the R-loom Run loom tests on this PR label Dec 30, 2022
@@ -191,10 +192,8 @@ mod abort;
mod join;

#[cfg(feature = "rt")]
#[allow(unreachable_pub)] // https://github.com/rust-lang/rust/issues/57411
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also curious if this is still needed.

@github-actions github-actions bot added the R-loom Run loom tests on this PR label Dec 30, 2022
@carllerche carllerche removed the R-loom Run loom tests on this PR label Dec 30, 2022
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Dec 30, 2022
@carllerche carllerche removed the R-loom Run loom tests on this PR label Dec 30, 2022
@carllerche carllerche merged commit 048049f into master Dec 30, 2022
@carllerche carllerche deleted the move-task-id-to-own-file branch December 30, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants