Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to diagnose a CI failure, please ignore #4800

Closed
wants to merge 1 commit into from

Commits on Jul 2, 2022

  1. tests: alter integration tests for stdio to not use a handrolled cat …

    …implementation
    
    This fixes #4801, where, as a result of rust-lang/rust#95469, our implementation of cat used for this test no longer works, as stdio functions on windows now can abort the process if the pipe is set to nonblocking mode.
    
    Unfortunately in windows, setting one end of the pipe to be nonblocking makes the whole thing nonblocking, so when, in tokio::process we set the child pipes to nonblocking mode, it causes serious problems for any rust program at the other end.
    
    Fixing this issue is for another day, but fixing the tests is for today.
    Noah-Kennedy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    5e271d7 View commit details
    Browse the repository at this point in the history