Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: add feature std for winapi #4663

Merged
merged 3 commits into from
May 8, 2022

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented May 8, 2022

Switching from winapi to windows-sys in mio means that the std feature of winapi is no longer enabled when compiling Tokio on windows. However, in this case, the c_void type is not the same as the c_void type in the standard library, which causes some compiler errors in various places.

(The first commit to this PR does not add the feature to verify that CI catches the issue when its not fixed.)

Closes: #4662

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label May 8, 2022
@Darksonn Darksonn merged commit 67074c3 into tokio-rs:master May 8, 2022
@Darksonn Darksonn deleted the winapi-std-feature branch May 8, 2022 18:14
@Milo123459
Copy link
Contributor

Will a new release be created for this hot-fix?

Darksonn added a commit that referenced this pull request May 8, 2022
@Darksonn Darksonn mentioned this pull request May 8, 2022
Darksonn added a commit that referenced this pull request May 8, 2022
@Darksonn Darksonn mentioned this pull request May 8, 2022
@Darksonn
Copy link
Contributor Author

Darksonn commented May 8, 2022

Yes, see #4666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokio v1.18.1 not compiling on Windows 10
4 participants