Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly relaxed clippy lint for runtime entry macro #4030

Merged

Conversation

kate-shine
Copy link
Contributor

This change explicitly allows clippy::expect for the .expect() used in the entry macro

Motivation

Our projects have a strict clippy setting and currently, the tokio::main macro breaks our pipelines.

Solution

#[allow(clippy::expect_used)] for the runtime build command :)

@taiki-e taiki-e added the A-tokio-macros Area: The tokio-macros crate label Aug 6, 2021
tokio-macros/src/entry.rs Outdated Show resolved Hide resolved
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kate-shine
Copy link
Contributor Author

Thanks!

Thank you for your patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio-macros Area: The tokio-macros crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants