net: add epollhup test #3898
Merged
net: add epollhup test #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like the behavior is different on mac. |
Thomasdezeeuw
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
LGTM.
@Darksonn have you mean able to reproduce the issue in #3879? Or is this just checking all errors. @bnoordhuis suggested in #3879 (comment) that this error might not be fatal.
|
Well, the test I added fails without the change. I didn't try other things than the test. |
|
We should probably do the same w/ TCP? |
|
We already do this for TCP as seen here, however when I added the test for TCP it didn't seem to work. |
This reverts commit 9509b62.
|
The TCP test might require setting linger to 0. Either way, we can merge this I think. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3879